Review Request (M) 8032379: Remove the is_scavenging flag to process_strong_roots (original) (raw)

Erik Helin erik.helin at oracle.com
Wed Jan 22 14:35:47 UTC 2014

Looks good!

Thanks, Erik

On 2014-01-21 14:13, Mikael Gerdin wrote:

Hi all,

as a part of implementing JEP-156 (G1 class unloading) we are doing some cleanups in order to refactor the strong root processing code. Currently there are two "dimensions" in which SharedHeap::processstrongroots is configured. One is the ScanOption enum, the other is the isscavenging booelan. The semantic meaning of isscavenging can easily be folded into the ScanOption enum by: * Introducing a SOAllCodeCache/SOScavengeCodeCache distinction (in a way similar to SOAllClasses/SOSystemClasses) * Noting that passing a CLD closure to Threads::oopsdo is only needed when we want to determine the precise liveness of classes, this is already signaled by SOSystemClasses. Bug link: https://bugs.openjdk.java.net/browse/JDK-8032379 Webrev: http://cr.openjdk.java.net/~mgerdin/8032379/webrev.0 Thanks /Mikael

More information about the hotspot-gc-dev mailing list