RFR (S): 8199326: Remove G1 gc time stamp logic (original) (raw)
Stefan Johansson stefan.johansson at oracle.com
Mon Mar 12 15:48:30 UTC 2018
- Previous message (by thread): RFR (S): 8199326: Remove G1 gc time stamp logic
- Next message (by thread): RFR (S): 8199326: Remove G1 gc time stamp logic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Thomas,
On 2018-03-08 16:46, Thomas Schatzl wrote:
On Thu, 2018-03-08 at 16:18 +0100, Stefan Johansson wrote:
Hi Thomas,
On 2018-03-08 14:33, Thomas Schatzl wrote: Hi,
with the rebuild remsets concurrently changes the last user of the gc time stamps (create live data) has gone away. This change removes all of the corresponding code I could find. Could you review it? CR: https://bugs.openjdk.java.net/browse/JDK-8199326 Webrev: http://cr.openjdk.java.net/~tschatzl/8197932/webrev/ Looks like you pasted the wrong link, and I couldn't find the correct one either. Sorry. The correct link is: http://cr.openjdk.java.net/~tschatzl/8199326/webrev Thanks for doing this cleanup, I found one more reference to the GC timestamp in g1CollectedHeap.hpp: 296 // Clear RSets after a compaction. It also resets the GC time stamps. 297 void clear_rsets_post_compaction();
You can actually remove those two lines completely if you like. I forgot the declaration when removing this method in the fix for: 8177544: Restructure G1 Full GC code
Otherwise the change looks good and if you don't want to remove the declaration in this patch we can create a separate clean up for this.
Cheers, Stefan
Thomas
- Previous message (by thread): RFR (S): 8199326: Remove G1 gc time stamp logic
- Next message (by thread): RFR (S): 8199326: Remove G1 gc time stamp logic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]