RFR (S): 8199326: Remove G1 gc time stamp logic (original) (raw)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Mar 13 13:42:13 UTC 2018

Hi,

On Mon, 2018-03-12 at 16:48 +0100, Stefan Johansson wrote:

Hi Thomas, [...] > > Sorry. The correct link is: > http://cr.openjdk.java.net/~tschatzl/8199326/webrev

Thanks for doing this cleanup, I found one more reference to the GC timestamp in g1CollectedHeap.hpp: 296 // Clear RSets after a compaction. It also resets the GC time stamps. 297 void clearrsetspostcompaction(); You can actually remove those two lines completely if you like. I forgot the declaration when removing this method in the fix for: 8177544: Restructure G1 Full GC code Otherwise the change looks good and if you don't want to remove the declaration in this patch we can create a separate clean up for this.

thanks for your review. I posted a webrev for the removal of this code as imho it does not completely fit here.

Thanks, Thomas

More information about the hotspot-gc-dev mailing list