RFR (M): 8151171: Bring g1ConcurrentMark files up to current coding conventions (original) (raw)
Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 26 15:14:35 UTC 2018
- Previous message (by thread): RFR (M): 8199742: Clean up state flags in G1CollectorState
- Next message (by thread): RFR (M): 8151171: Bring g1ConcurrentMark files up to current coding conventions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi all,
can I have reviews for this mostly renaming patch that cleans up g1ConcurrentMark files (once again sigh).
Changes:
- camelCase variable and method naming
- missing brackets around one-line if-statement bodies.
- method naming (getters/setters)
- use _g1h member variable instead of _g1 or another method local variable as discussed earlier
- use assert_at_safepoint* macros
- remove incomprehensible comments
- changed "CheckPointRoots" to "Remark" throughout ...
CR: https://bugs.openjdk.java.net/browse/JDK-8151171 Webrev: http://cr.openjdk.java.net/~tschatzl/8151171/webrev Testing: hs-tier 1-5 in conjunction with JDK-8200234, hs-tier 1 standalone
The webrev is based on JDK-8199742 also out for review, but has no particular semantic connection.
Thanks, Thomas
- Previous message (by thread): RFR (M): 8199742: Clean up state flags in G1CollectorState
- Next message (by thread): RFR (M): 8151171: Bring g1ConcurrentMark files up to current coding conventions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]