RFR (M): 8151171: Bring g1ConcurrentMark files up to current coding conventions (original) (raw)

Stefan Johansson stefan.johansson at oracle.com
Wed Mar 28 11:26:24 UTC 2018

Hi Thomas,

Very nice cleanup.

On 2018-03-26 17:14, Thomas Schatzl wrote:

Hi all,

can I have reviews for this mostly renaming patch that cleans up g1ConcurrentMark files (once again sigh). Changes: - camelCase variable and method naming - missing brackets around one-line if-statement bodies. - method naming (getters/setters) - use g1h member variable instead of g1 or another method local variable as discussed earlier - use assertatsafepoint* macros - remove incomprehensible comments - changed "CheckPointRoots" to "Remark" throughout ... CR: https://bugs.openjdk.java.net/browse/JDK-8151171 Webrev: http://cr.openjdk.java.net/~tschatzl/8151171/webrev Looks good, just to have one comment ;) src/hotspot/share/gc/g1/concurrentMarkThread.cpp 331           CMRemark final_cl(_cm); 362         CMCleanup cl_cl(_cm);

Rename the instances to remark and cleanup.

Thanks, Stefan

Testing: hs-tier 1-5 in conjunction with JDK-8200234, hs-tier 1 standalone

The webrev is based on JDK-8199742 also out for review, but has no particular semantic connection. Thanks, Thomas

More information about the hotspot-gc-dev mailing list