Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling (original) (raw)
David Holmes David.Holmes at oracle.com
Wed Jan 5 15:15:49 PST 2011
- Previous message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Next message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Coleen Phillimore said the following on 01/06/11 06:14:
Summary: Call getthreadslow() in vmperformshutdown actions and add null check.
Looks fine. A minor nit - you'd preserve the abstraction boundary more if you checked is_initialized() rather than explicitly comparing the index against -1
Cheers, David
Tested by forcing vmexitoutofmemory in currentstackregion (if isinitcompleted) to reproduce the bug.
open webrev at http://cr.openjdk.java.net/~coleenp/6583275/ bug link at http://bugs.sun.com/viewbug.do?bugid=6583275 Thanks, Coleen
- Previous message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Next message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]