Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling (original) (raw)
John Coomes John.Coomes at oracle.com
Wed Jan 5 15:26:20 PST 2011
- Previous message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Next message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
Summary: Call getthreadslow() in vmperformshutdown actions and add null check.
Tested by forcing vmexitoutofmemory in currentstackregion (if isinitcompleted) to reproduce the bug. open webrev at http://cr.openjdk.java.net/~coleenp/6583275/ bug link at http://bugs.sun.com/viewbug.do?bugid=6583275
You should use ThreadLocalStorage::is_initialized() instead of checking for -1. Other than that, looks good.
-John
- Previous message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Next message: Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]