Pls review 7011463 (S) (original) (raw)
John Coomes John.Coomes at oracle.com
Tue Jan 11 09:50:53 PST 2011
- Previous message: Pls review 7011463 (S)
- Next message: Pls review 7011463 (S)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Christian Thalinger (christian.thalinger at oracle.com) wrote:
On Jan 11, 2011, at 12:25 PM, Paul Hohensee wrote: > Sparc MacroAssembler::incrallocatedbytes() needs a RegisterOrConstant argument. > > Webrev here > > http://cr.openjdk.java.net/~phh/7011463/webrev.00/ > > Christian, I should have implemented your suggestion. :( > > Turns out that some constant object sizes are larger than 4kb (what fits in a simm13), > which will cause assertions once in awhile when an attempt is made to generate > an add-immediate instruction.
Looks good. Other uses of RegisterOrConstant don't call the constructor explicitly when passing in as argument, but that's just a nit.
Looks good to me also. In case you're taking a poll, I'd vote to remove the explicit calls to the ctor to reduce clutter.
-John
- Previous message: Pls review 7011463 (S)
- Next message: Pls review 7011463 (S)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]