Pls review 7011463 (S) (original) (raw)
Paul Hohensee paul.hohensee at oracle.com
Tue Jan 11 14:16:42 PST 2011
- Previous message: Pls review 7011463 (S)
- Next message: Request for reviews (XS): 7011386: race in objArrayKlass::array_klass_impl
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Done.
On 1/11/11 12:50 PM, John Coomes wrote:
Christian Thalinger (christian.thalinger at oracle.com) wrote:
On Jan 11, 2011, at 12:25 PM, Paul Hohensee wrote:
Sparc MacroAssembler::incrallocatedbytes() needs a RegisterOrConstant argument.
Webrev here http://cr.openjdk.java.net/~phh/7011463/webrev.00/ Christian, I should have implemented your suggestion. :( Turns out that some constant object sizes are larger than 4kb (what fits in a simm13), which will cause assertions once in awhile when an attempt is made to generate an add-immediate instruction. Looks good. Other uses of RegisterOrConstant don't call the constructor explicitly when passing in as argument, but that's just a nit. Looks good to me also. In case you're taking a poll, I'd vote to remove the explicit calls to the ctor to reduce clutter. -John
- Previous message: Pls review 7011463 (S)
- Next message: Request for reviews (XS): 7011386: race in objArrayKlass::array_klass_impl
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]