RFR (S): JDK-8138562 Event based tracing should cover monitor inflation (original) (raw)

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Oct 5 23:45:57 UTC 2015

On 10/5/15 1:41 AM, David Simms wrote:

Greetings,

Please review the addition of event based tracing at monitor inflation time... Webrev: http://cr.openjdk.java.net/~dsimms/8138562/

src/share/vm/runtime/synchronizer.cpp L1316: event.cancel(); // lets not post an inflation event, unless we did the deed ourselves Typo: "lets" -> "let's"

src/share/vm/runtime/synchronizer.hpp L110: static ObjectMonitor* inflate(Thread * Self, oop obj, InflateCause cause = inflate_cause_vm_internal);

     I hate default parameter values! :-)

     Shouldn't 'cause' be a const?

 L113:   static const char* inflate_cause_name(InflateCause cause);

     Shouldn't 'cause' be a const?

 L166:   static void

post_monitor_inflate_event(EventJavaMonitorInflate* event, L167: oop obj, L168: InflateCause cause);

     Shouldn't 'obj' and 'cause' both be a const?

src/share/vm/trace/trace.xml No comments.

src/share/vm/trace/traceEventClasses.xsl No comments.

src/share/vm/trace/tracetypes.xml No comments.

Pretty minor stuff. Thumbs up and I don't need to see another webrev if you chose to fix these.

Dan

Bug: https://bugs.openjdk.java.net/browse/JDK-8138562

Cheers /David Simms

More information about the hotspot-runtime-dev mailing list