RFR (S): JDK-8138562 Event based tracing should cover monitor inflation (original) (raw)
David Simms david.simms at oracle.com
Tue Oct 6 08:40:46 UTC 2015
- Previous message: RFR (S): JDK-8138562 Event based tracing should cover monitor inflation
- Next message: RFR(XS): 8137260: fix warning after "8046148: JEP 158: Unified JVM Logging"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks for the review Dan,
All your comments applied, cheers
/David Simms
On 06/10/15 01:45, Daniel D. Daugherty wrote:
On 10/5/15 1:41 AM, David Simms wrote:
Greetings,
Please review the addition of event based tracing at monitor inflation time... Webrev: http://cr.openjdk.java.net/~dsimms/8138562/ src/share/vm/runtime/synchronizer.cpp L1316: event.cancel(); // lets not post an inflation event, unless we did the deed ourselves Typo: "lets" -> "let's" src/share/vm/runtime/synchronizer.hpp L110: static ObjectMonitor* inflate(Thread * Self, oop obj, InflateCause cause = inflatecausevminternal); I hate default parameter values! :-) Shouldn't 'cause' be a const? L113: static const char* inflatecausename(InflateCause cause); Shouldn't 'cause' be a const? L166: static void postmonitorinflateevent(EventJavaMonitorInflate* event, L167: oop obj, L168: InflateCause cause); Shouldn't 'obj' and 'cause' both be a const? src/share/vm/trace/trace.xml No comments. src/share/vm/trace/traceEventClasses.xsl No comments. src/share/vm/trace/tracetypes.xml No comments. Pretty minor stuff. Thumbs up and I don't need to see another webrev if you chose to fix these. Dan
Bug: https://bugs.openjdk.java.net/browse/JDK-8138562 Cheers /David Simms
- Previous message: RFR (S): JDK-8138562 Event based tracing should cover monitor inflation
- Next message: RFR(XS): 8137260: fix warning after "8046148: JEP 158: Unified JVM Logging"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]