RFR: 8213204 - ReservedStackTest and ReservedStackTestCompiler tests fail on windows (original) (raw)
Bob Vandette bob.vandette at oracle.com
Wed Oct 31 19:06:45 UTC 2018
- Previous message: RFR (XS) 8213182: Minimal VM build failure after JDK-8212200 (assert when shared java.lang.Object is redefined by JVMTI agent)
- Next message: RFR: 8213204 - ReservedStackTest and ReservedStackTestCompiler tests fail on windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Please review this test fix that solve a problem with a regression that was introduced with the changes done to remove one of the AARCH64 ports (https://bugs.openjdk.java.net/browse/JDK-8209093).
BUG: https://bugs.openjdk.java.net/browse/JDK-8213204
WEBREV: http://cr.openjdk.java.net/~bobv/8213204/webrev
Here is the effective change that I should have done to this test when removing the Hybrid arm64 port.
diff --git a/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java b/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java --- a/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java +++ b/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java @@ -233,19 +233,16 @@ }
private static boolean isAlwaysSupportedPlatform() {// Note: To date Aarch64 is the only platform that we don't statically// know if it supports the reserved stack area. This is because the// open Aarch64 port supports it and the Oracle arm64 port does not. return Platform.isAix() || (Platform.isLinux() && (Platform.isPPC() || Platform.isS390x() || Platform.isX64() ||Platform.isX86())) ||
Platform.isX86() || Platform.isAArch64())) || Platform.isOSX() || Platform.isSolaris();}
private static boolean isNeverSupportedPlatform() {
return !isAlwaysSupportedPlatform() && !Platform.isAArch64();
return !isAlwaysSupportedPlatform();}
private static boolean isSupportedPlatform;
Bob.
- Previous message: RFR (XS) 8213182: Minimal VM build failure after JDK-8212200 (assert when shared java.lang.Object is redefined by JVMTI agent)
- Next message: RFR: 8213204 - ReservedStackTest and ReservedStackTestCompiler tests fail on windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]