RFR: 8213204 - ReservedStackTest and ReservedStackTestCompiler tests fail on windows (original) (raw)

Frederic Parain frederic.parain at oracle.com
Wed Oct 31 19:12:27 UTC 2018

Looks good to me. Thank you for fixing this.

Fred

On Oct 31, 2018, at 15:06, Bob Vandette <bob.vandette at oracle.com> wrote:

Please review this test fix that solve a problem with a regression that was introduced with the changes done to remove one of the AARCH64 ports (https://bugs.openjdk.java.net/browse/JDK-8209093). BUG: https://bugs.openjdk.java.net/browse/JDK-8213204 WEBREV: http://cr.openjdk.java.net/~bobv/8213204/webrev

Here is the effective change that I should have done to this test when removing the Hybrid arm64 port. diff --git a/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java b/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java --- a/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java +++ b/test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java @@ -233,19 +233,16 @@ } private static boolean isAlwaysSupportedPlatform() { - // Note: To date Aarch64 is the only platform that we don't statically - // know if it supports the reserved stack area. This is because the - // open Aarch64 port supports it and the Oracle arm64 port does not. return Platform.isAix() || (Platform.isLinux() && (Platform.isPPC() || Platform.isS390x() || Platform.isX64() || - Platform.isX86())) || + Platform.isX86() || Platform.isAArch64())) || Platform.isOSX() || Platform.isSolaris(); } private static boolean isNeverSupportedPlatform() { - return !isAlwaysSupportedPlatform() && !Platform.isAArch64(); + return !isAlwaysSupportedPlatform(); } private static boolean isSupportedPlatform; Bob.

More information about the hotspot-runtime-dev mailing list