Resent: Push request: 7043847...: NTLM API compliances issues (original) (raw)

Weijun Wang weijun.wang at oracle.com
Fri Aug 19 00:03:49 PDT 2011

Hi Edvard

I've just uploaded a webrev at --

http://cr.openjdk.java.net/~weijun/7043847-7u/webrev.00/

After comparing it with the webrev for JDK 8 at --

http://cr.openjdk.java.net/~weijun/7043847/webrev.00/

I found they are actually identical!

In fact, it is inside JDK 8 that another changeset on the same files was pushed after my local changeset is created. Therefore when it's time for me to push my changeset, I see a conflict and have to do a merge and push an updated one. I use Mercurial Queue, so there is no "Merge" changeset.

So, precisely I should say:

The webrev for jdk7u2 is identical to the one in jdk8. The changeset is a little different due to the merge.

Do I still need a code review? :)

Thanks Max

On 08/19/2011 02:41 PM, Edvard Wendelin wrote:

Hi,

Thanks for the request! Since the fix is not identical to the one in 8 (I know, nagging about two small changes is picky, but we had to draw the line somewhere), you'll need to post a webrev on cr.openjdk.java.net and get one additional review. Once the webrev is uploaded, please send us a link to it. Cheers, Edvard On 19 aug 2011, at 08.09, Weijun Wang wrote:

Sorry, forget to update the subject line in my template. Sent again.

-------- Original Message -------- Subject: Push request: nnnnnnn: so so Date: Fri, 19 Aug 2011 14:00:32 +0800 From: Weijun Wang <weijun.wang at oracle.com> To: jdk7u-dev at openjdk.java.net Hi All This is a request to backport several jdk8 fix into jdk7u2 b03: CR: 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Weblink: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7043847 http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7043860 http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7043882 http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7043938 http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7043959 Description: The NTLM mechanism for SASL has several API compliance issues when an error occurs during the communication, say, throwing an UnsupportedOperationException when an IllegalStateException is expected, or, throwing a NullPointerException when a SaslException is expected. The fix is already included in jdk8 as: Changeset: 55952703809f Author: weijun Date: 2011-08-19 13:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55952703809f 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: vinnie The patch for jdk7u2 is almost identical to the one in jdk8. There are only 2 places where the context differs a little. I intend to push it to ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Thanks Weijun

More information about the jdk7u-dev mailing list