Resent: Push request: 7043847...: NTLM API compliances issues (original) (raw)

Dalibor Topic dalibor.topic at oracle.com
Fri Aug 19 02:20:50 PDT 2011

On 8/19/11 9:03 AM, Weijun Wang wrote:

Hi Edvard

I've just uploaded a webrev at -- http://cr.openjdk.java.net/~weijun/7043847-7u/webrev.00/ After comparing it with the webrev for JDK 8 at -- http://cr.openjdk.java.net/~weijun/7043847/webrev.00/ I found they are actually identical! In fact, it is inside JDK 8 that another changeset on the same files was pushed after my local changeset is created. Therefore when it's time for me to push my changeset, I see a conflict and have to do a merge and push an updated one. I use Mercurial Queue, so there is no "Merge" changeset. So, precisely I should say: The webrev for jdk7u2 is identical to the one in jdk8. The changeset is a little different due to the merge. Do I still need a code review? :)

Nope - if it's the same patch as in 8, you're good to go, and it is in this case.

cheers, dalibor topic

Oracle <http://www.oracle.com> Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

More information about the jdk7u-dev mailing list