Review Request: Warnings cleanup in sun.management and its subpackages (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Mon Dec 5 08:44:45 PST 2011
- Previous message: Review Request: Warnings cleanup in sun.management and its subpackages
- Next message: Review Request: Warnings cleanup in sun.management and its subpackages
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Some trivial comments: ConnectorAddressLink.java L172 - L178, you can use 'for(Counter c: counters)' and remove subsequent redundant cases. MappedMXBeanType.java L76, cast to (Class<?) ???
Some of the public classes have API changes. Are these classes in any way supported? Some have Javadoc comments that would make me think this, but maybe not given the name space.
-Chris.
On 02/12/2011 23:09, Kurchi Hazra wrote:
Hi,
http://cr.openjdk.java.net/~khazra/7117570/webrev.00/ Please review this webrev that cleans warnings in sun.management and its subpackages. These packages are now warning-free I believe. Looking forward to your comments. I have used the serialver tool to generate all the serial version UIDs that I have added.
Thanks, Kurchi
- Previous message: Review Request: Warnings cleanup in sun.management and its subpackages
- Next message: Review Request: Warnings cleanup in sun.management and its subpackages
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]