Review Request: Warnings cleanup in sun.management and its subpackages (original) (raw)

Kurchi Hazra kurchi.subhra.hazra at oracle.com
Mon Dec 5 11:49:21 PST 2011

On 12/5/2011 8:44 AM, Chris Hegarty wrote:

Some trivial comments: ConnectorAddressLink.java L172 - L178, you can use 'for(Counter c: counters)' and remove subsequent redundant cases. MappedMXBeanType.java L76, cast to (Class<?) ???

Thanks! I changed these.

Some of the public classes have API changes. Are these classes in any way supported? Some have Javadoc comments that would make me think this, but maybe not given the name space.

I tried being careful - but I guess I did touch public classes. Maybe I will wait for Mandy's review and go over these again, and then send out a final webrev.

-Chris. On 02/12/2011 23:09, Kurchi Hazra wrote: Hi,

http://cr.openjdk.java.net/~khazra/7117570/webrev.00/ Please review this webrev that cleans warnings in sun.management and its subpackages. These packages are now warning-free I believe. Looking forward to your comments. I have used the serialver tool to generate all the serial version UIDs that I have added.

Thanks, Kurchi

-- -Kurchi

More information about the jdk8-dev mailing list