RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Wed Nov 23 09:57:07 PST 2011
- Previous message: hg: jdk8/tl/jdk: 7102369: remove java.rmi.server.codebase property parsing from registyimpl; ...
- Next message: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
This CR is simply to cleanup the style of the java.net.HttpCookie source code. This has bugged me for a while!
- Remove extraneous newlines
- Use consistent javadoc comment style
- Fix typos in public specification, specifically: http->HTTP, url->URL, seperated->separated, llegal->illegal
- Where possible limit code to 80 columns
Minor implementation changes
- Make 'name', 'assignors', and 'whenCreated', final since they are immutable
- Remove unnecessary StringBuilder from toNetscapeHeaderString ( since it is using String concatenation )
- Use diamond in ArrayList construction, parse()
For ease of review I generated HTML diffs of the javadoc (see webrev). Reviewers can simply scan the javadoc diffs, and scan the new source file for style ( and be confident that there are no spec changes ).
http://cr.openjdk.java.net/~chegar/7115150/webrev.00/webrev/
Thanks, -Chris.
- Previous message: hg: jdk8/tl/jdk: 7102369: remove java.rmi.server.codebase property parsing from registyimpl; ...
- Next message: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]