RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos (original) (raw)
Michael McMahon michael.x.mcmahon at oracle.com
Fri Nov 25 02:02:42 PST 2011
- Previous message: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos
- Next message: hg: jdk8/tl/langtools: 2 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me.
- Michael.
On 23/11/11 17:57, Chris Hegarty wrote:
This CR is simply to cleanup the style of the java.net.HttpCookie source code. This has bugged me for a while!
1) Remove extraneous newlines 2) Use consistent javadoc comment style 3) Fix typos in public specification, specifically: http->HTTP, url->URL, seperated->separated, llegal->illegal 4) Where possible limit code to 80 columns Minor implementation changes 1) Make 'name', 'assignors', and 'whenCreated', final since they are immutable 2) Remove unnecessary StringBuilder from toNetscapeHeaderString ( since it is using String concatenation ) 3) Use diamond in ArrayList construction, parse() For ease of review I generated HTML diffs of the javadoc (see webrev). Reviewers can simply scan the javadoc diffs, and scan the new source file for style ( and be confident that there are no spec changes ). http://cr.openjdk.java.net/~chegar/7115150/webrev.00/webrev/ Thanks, -Chris.
- Previous message: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos
- Next message: hg: jdk8/tl/langtools: 2 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]