Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl() (original) (raw)
serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Jan 28 16:24:04 PST 2013
- Previous message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Next message: Review Request (XS) 8006731: JSR 292: the VM_RedefineClasses::rewrite_cp_refs_in_method() must support invokedynamic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks! In fact, I did not test it with all the mlvm nsk tests, but agreed it is worth to do. I'll run the mlvm tests before the integration.
Thanks, Serguei
On 1/28/13 3:55 PM, Coleen Phillimore wrote:
This looks good. I assume that this is tested with the mlvm nsk tests? Thanks, Coleen On 1/28/2013 5:33 PM, serguei.spitsyn at oracle.com wrote: Please, review the fix for (it was already reviewed by Christian): https://jbs.oracle.com/bugs/browse/JDK-8006546
Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006546-JVMTI-JSR292.0
Summary: The copyoperands() does the same copy frrom dest cpool twice in two places. Instead, it must copy once from dest and once from source cpool. It would make it consistent with the comments. Testing: nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist, vm/mlvm/indy/func/jvmti/redefineClassInBootstrap Thanks, Serguei
- Previous message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Next message: Review Request (XS) 8006731: JSR 292: the VM_RedefineClasses::rewrite_cp_refs_in_method() must support invokedynamic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]