[Python-Dev] Direction of PyChecker (original) (raw)
Neal Norwitz neal@metaslash.com
Fri, 10 Aug 2001 15:56:25 -0400
- Previous message: [Python-Dev] Direction of PyChecker
- Next message: [Python-Dev] Direction of PyChecker
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Guido van Rossum wrote:
> As I said before, I think that the modules/classes > in the standard library should have them. You can help by submitting some patches (one module at a time please :-).
I'll do my best. And this time, I'll post to SF, with link here. :-)
> And docstrings are definitely > doc, not code.
Agreed, but I don;'t understand why you said this.
I was just pointing out that docstrings should not be warned about and that they won't be in the future (about 5 minutes :-).
> > There are also complaints about attribute used by an > > abstract base class but only defined in the subclass. > > This is true. While python doesn't require setting, I think this feature > can be dangerous. It seems better to init the attr to None.
Agreed. The initialization to None can have a comment explaining what the subclass should do. Ditto for methods: in an abstract base class, the methods should be defined (so the signature is known) but raise NotImplementedError.
I will try to create patches for a lot of these warnings as well then. I think there are already comments, so I will just init to None.
> In urllib2, there are 6 warnings about 2 different attributes.
How come PyChecker didn't find the other typo there?
Not sure. What was broken? Was it in 2.2a1 or cvs? (I ran against 2.2a1.)
Neal
- Previous message: [Python-Dev] Direction of PyChecker
- Next message: [Python-Dev] Direction of PyChecker
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]