[Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments. (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Wed Apr 18 15:39:34 CEST 2012
- Previous message: [Python-Dev] webbrowser no longer support 'internet-config' on Mac
- Next message: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin <python-checkins at python.org> wrote:
- if (name == NULL) + if (name == NULL) { + PyINCREF(PyNone); name = PyNone; + }
A slightly more traditional way to write that would be:
name = Py_None;
Py_INCREF(name);- if (path == NULL) + if (path == NULL) { + PyINCREF(PyNone); path = PyNone; + }
Ditto.
PyINCREF(msg); - PyTupleSetItem(args, 0, msg); + PyTupleSetItem(args, 0, NULL);//msg);
However, this looks a lot more suspicious... accidental commit of debugging code?
(if not for spotting this last problem, I wouldn't have even mentioned the first two)
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] webbrowser no longer support 'internet-config' on Mac
- Next message: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]