[Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments. (original) (raw)
R. David Murray rdmurray at bitdance.com
Wed Apr 18 16:08:10 CEST 2012
- Previous message: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.
- Next message: [Python-Dev] cpython: Fix email post-commit review comments.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
We're seeing segfuilts on the buildbots now. Example:
http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/5715
On Wed, 18 Apr 2012 23:39:34 +1000, Nick Coghlan <ncoghlan at gmail.com> wrote:
On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin <python-checkins at python.org> wrote: > - Â Â if (name == NULL) > + Â Â if (name == NULL) { > + Â Â Â Â PyINCREF(PyNone); > Â Â Â Â name = PyNone; > + Â Â }
A slightly more traditional way to write that would be: name = PyNone; PyINCREF(name); > -   if (path == NULL) > +   if (path == NULL) { > +     PyINCREF(PyNone); >     path = PyNone; > +   } Ditto. > >   PyINCREF(msg); > -   PyTupleSetItem(args, 0, msg); > +   PyTupleSetItem(args, 0, NULL);//msg); However, this looks a lot more suspicious... accidental commit of debugging code? (if not for spotting this last problem, I wouldn't have even mentioned the first two) Cheers, Nick. -- Nick Coghlan  |  ncoghlan at gmail.com  |  Brisbane, Australia
Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/rdmurray%40bitdance.com
- Previous message: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.
- Next message: [Python-Dev] cpython: Fix email post-commit review comments.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]