Issue 34382: test_os.test_mode fails when directory base directory has g+s set (original) (raw)

Created on 2018-08-11 12:31 by Michael.Felt, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8737 closed Michael.Felt,2018-08-11 12:37
Messages (5)
msg323414 - (view) Author: Michael Felt (Michael.Felt) * Date: 2018-08-11 12:31
test_mode assumes that the SGID bit is not set in the parent directory. If it is set the assertEqual() tests fail. This PR checks the mode of 'base' to see if the SGID bit is set, or not, and compares results accordingly. Back-porting requested.
msg323672 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-08-17 21:19
'Backport' might or might not mean 2.7. You should be able to explicitly select versions in the box above. I have no idea who should review this.
msg323726 - (view) Author: Michael Felt (Michael.Felt) * Date: 2018-08-18 18:51
Likewise, I have no idea who should review, or whether python2 should be included or not. The issue is not a bug in python, rather a shortcoming in the test suite. In short, since I do my builds in an environment where the mode includes SGID on the directory i see this “false” fail. Sent from my iPhone > On 17 Aug 2018, at 23:19, Terry J. Reedy <report@bugs.python.org> wrote: > > > Terry J. Reedy <tjreedy@udel.edu> added the comment: > > 'Backport' might or might not mean 2.7. You should be able to explicitly select versions in the box above. I have no idea who should review this. > > ---------- > nosy: +terry.reedy > > _______________________________________ > Python tracker <report@bugs.python.org> > <https://bugs.python.org/issue34382> > _______________________________________ >
msg324411 - (view) Author: Michael Felt (Michael.Felt) * Date: 2018-08-31 09:27
For now, backport only means, imho to 3.7 and maybe 3.6. More could be merrier - but the goal is to clear the buildbots for regression testing. This one is quite simple - so adding 2.7 to the list of backports would be great.
msg325480 - (view) Author: Michael Felt (Michael.Felt) * Date: 2018-09-16 11:24
Closing this, and my PR, as is a repeat and already merged.
History
Date User Action Args
2022-04-11 14:59:04 admin set github: 78563
2018-09-16 11:24:13 Michael.Felt set status: open -> closedmessages: + stage: patch review -> resolved
2018-08-31 09:27:33 Michael.Felt set messages: + versions: + Python 2.7, Python 3.6, Python 3.7
2018-08-18 18:51:46 Michael.Felt set messages: +
2018-08-17 21:19:39 terry.reedy set nosy: + terry.reedymessages: +
2018-08-11 12:37:19 Michael.Felt set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest8224>
2018-08-11 12:31:06 Michael.Felt create