Issue 35946: Ambiguous documentation for assert_called_with() (original) (raw)
Created on 2019-02-08 22:15 by chimaerase, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11796 | merged | remi.lapeyre,2019-02-08 22:37 | |
| PR 11796 | merged | remi.lapeyre,2019-02-08 22:37 | |
| PR 11796 | merged | remi.lapeyre,2019-02-08 22:37 | |
| PR 15579 | merged | miss-islington,2019-08-29 06:16 |
| Messages (6) | ||
|---|---|---|
| msg335112 - (view) | Author: Mark Forrer (chimaerase) | Date: 2019-02-08 22:15 |
| The documentation for assert_called_with() is ambiguous with regard to the fact that the method only checks the most recent call. This behavior for assert_called_with() is only documented under assert_any_call(), which users are unlikely to read when making quick reference to the documentation. | ||
| msg335114 - (view) | Author: Rémi Lapeyre (remi.lapeyre) * | Date: 2019-02-08 22:39 |
| Hi Mark Forrer, I opened a new PR to add this precision to assert_called_with documentation. | ||
| msg335119 - (view) | Author: Mark Forrer (chimaerase) | Date: 2019-02-08 23:53 |
| Thank you Rémi! Thanks, --Mark-- On Fri, Feb 8, 2019 at 2:39 PM Rémi Lapeyre <report@bugs.python.org> wrote: > > Rémi Lapeyre <remi.lapeyre@henki.fr> added the comment: > > Hi Mark Forrer, I opened a new PR to add this precision to > assert_called_with documentation. > > ---------- > nosy: +remi.lapeyre > versions: +Python 3.8 > > _______________________________________ > Python tracker <report@bugs.python.org> > <https://bugs.python.org/issue35946> > _______________________________________ > | ||
| msg350727 - (view) | Author: Ned Deily (ned.deily) *  |
Date: 2019-08-29 06:15 |
| New changeset f5896a05edf5df91fb1b55bd481ba5b2a3682f4e by Ned Deily (Rémi Lapeyre) in branch 'master': bpo-35946: Improve assert_called_with documentation (GH-11796) https://github.com/python/cpython/commit/f5896a05edf5df91fb1b55bd481ba5b2a3682f4e | ||
| msg350734 - (view) | Author: miss-islington (miss-islington) | Date: 2019-08-29 06:39 |
| New changeset 612d3935ec0b2fbe88b3fae8167f0c503c61a9ca by Miss Islington (bot) in branch '3.8': bpo-35946: Improve assert_called_with documentation (GH-11796) https://github.com/python/cpython/commit/612d3935ec0b2fbe88b3fae8167f0c503c61a9ca | ||
| msg350742 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2019-08-29 07:30 |
| Thanks for the report and thanks for the PR! Merged for 3.8.0b4. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:11 | admin | set | github: 80127 |
| 2019-08-29 07:30:23 | ned.deily | set | status: open -> closedversions: + Python 3.9, - Python 3.7messages: + keywords:patch, patch, patchresolution: fixedstage: patch review -> resolved |
| 2019-08-29 06:39:50 | miss-islington | set | nosy: + miss-islingtonmessages: + |
| 2019-08-29 06:16:25 | miss-islington | set | pull_requests: + <pull%5Frequest15255> |
| 2019-08-29 06:15:56 | ned.deily | set | nosy: + ned.deilymessages: + |
| 2019-02-08 23:53:24 | chimaerase | set | messages: + |
| 2019-02-08 22:39:20 | remi.lapeyre | set | nosy: + remi.lapeyremessages: + versions: + Python 3.8 |
| 2019-02-08 22:37:48 | remi.lapeyre | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest11802> |
| 2019-02-08 22:37:44 | remi.lapeyre | set | keywords: + patchstage: (no value)pull_requests: + <pull%5Frequest11801> |
| 2019-02-08 22:37:41 | remi.lapeyre | set | keywords: + patchstage: (no value)pull_requests: + <pull%5Frequest11800> |
| 2019-02-08 22:15:08 | chimaerase | create |