| msg337983 - (view) |
Author: Bernhard M. Wiedemann (bmwiedemann) * |
Date: 2019-03-15 12:30 |
| While working on reproducible builds for openSUSE, I found countless python modules that come with binary .so files that did not build reproducibly from non-deterministic filesystem readdir order. One contributing factor is bpo-30461 that will not be fixed. I found that a simple patch can be done in distutils instead of fixing an infinite number of current and future python modules. |
|
|
| msg348852 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2019-08-01 13:18 |
| New changeset 0d30ae1a03102de07758650af9243fd31211325a by Victor Stinner (Bernhard M. Wiedemann) in branch 'master': bpo-36302: Sort list of sources (GH-12341) https://github.com/python/cpython/commit/0d30ae1a03102de07758650af9243fd31211325a |
|
|
| msg348853 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-08-01 13:19 |
| I'm not excited about backporting this change to Python 3.8 and older. Python 3.8 also switch to its feature freeze for Python 3.8.0. This change is borderline between bugfix and feature. In case of doubt, I prefer to do nothing. See concerns in the PR discussion: https://github.com/python/cpython/pull/12341#issuecomment-473361985 |
|
|
| msg373024 - (view) |
Author: Ronald Oussoren (ronaldoussoren) * |
Date: 2020-07-05 10:17 |
| An unfortunate side effect of this change is that changes the build order even if the source list order is relevant. In particular, I sort the source list by age when working on larger extensions, this makes sure that the source files I edited last get compiled first, which speeds up edit/build cycles. |
|
|
| msg373106 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2020-07-06 12:04 |
| > An unfortunate side effect of this change is that changes the build order even if the source list order is relevant. That sounds like a new feature. I don't think that it was supported previously. Or maybe it was more an implementation detail. Please open a new issue if you would like to add the ability to specify in which order source files must be compiled. |
|
|
| msg373118 - (view) |
Author: Ronald Oussoren (ronaldoussoren) * |
Date: 2020-07-06 13:59 |
| That's the problem with any change to distutils, the API is unclear and that causes any change to be potentially breaking for existing users. That's why distutils has been mostly stagnant for years. I have no particular wish w.r.t. changing behaviour, I've a local workaround for now and am hoping someone will write a tool similar to flit for packages that include extensions. |
|
|
| msg386133 - (view) |
Author: Matej Cepl (mcepl) * |
Date: 2021-02-02 10:40 |
| > In particular, I sort the source list by age when working on larger extensions, this makes sure that the source files I edited last get compiled first, which speeds up edit/build cycles. On the one hand, this sounds creepily like https://xkcd.com/1172, but on the other: why do we need to sort those extensions by name? Wouldn’t sorting by some attribute of those extensions (including their size) be better? |
|
|
| msg386134 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2021-02-02 10:48 |
| > Why do we need to sort those extensions by name? Because calling sorted() is easy. Any other arbitrary choice would make sense. But giving the ability to build sources in a specific order, add dependencies, or something else, would a new features. Also, distutils is now deprecated in the stdlib: the steering council approved https://www.python.org/dev/peps/pep-0632/ You should now report distutils issues to setuptools. |
|
|