bpo-36302: Sort list of sources (GH-12341) · python/cpython@0d30ae1 (original) (raw)
Navigation Menu
- GitHub Copilot Write better code with AI
- GitHub Models New Manage and compare prompts
- GitHub Advanced Security Find and fix vulnerabilities
- Actions Automate any workflow
- Codespaces Instant dev environments
- Issues Plan and track work
- Code Review Manage code changes
- Discussions Collaborate outside of code
- Code Search Find more, search less
- Explore
- Pricing
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Commit 0d30ae1
authored and
committed
File tree
2 files changed
lines changed
2 files changed
lines changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -490,7 +490,8 @@ def build_extension(self, ext): | ||
| 490 | 490 | "in 'ext_modules' option (extension '%s'), " |
| 491 | 491 | "'sources' must be present and must be " |
| 492 | 492 | "a list of source filenames" % ext.name) |
| 493 | -sources = list(sources) | |
| 493 | +# sort to make the resulting .so file build reproducible | |
| 494 | +sources = sorted(sources) | |
| 494 | 495 | |
| 495 | 496 | ext_path = self.get_ext_fullpath(ext.name) |
| 496 | 497 | depends = sources + ext.depends |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| 1 | +distutils sorts source file lists so that Extension .so files | |
| 2 | +build more reproducibly by default |