Issue 43916: Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag (original) (raw)

Created on 2021-04-22 21:31 by pablogsal, last changed 2022-04-11 14:59 by admin.

Messages (72)

msg391634 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-22 21:31

I'm creating this issue and marking it as a deferred blocker to make sure we don't forget to check this (adding tests) before the release.

Check this message from Serhiy regarding heap typed concerns:

https://bugs.python.org/msg391598

msg391635 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-22 21:32

Serhiy's comment for reference:

Static type with tp_new = NULL does not have public constructor, but heap type inherits constructor from base class. As result, it allows to create instances without proper initialization, that can lead to crash. It was fixed for few standard heap types in , then reintroduced, then fixed again in . But it should be checked for every type without constructor.

msg391903 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 11:48

From Objects/typeobject.c:

    /* The condition below could use some explanation.
       It appears that tp_new is not inherited for static types
       whose base class is 'object'; this seems to be a precaution
       so that old extension types don't suddenly become
       callable (object.__new__ wouldn't insure the invariants
       that the extension type's own factory function ensures).
       Heap types, of course, are under our control, so they do
       inherit tp_new; static extension types that specify some
       other built-in type as the default also
       inherit object.__new__. */
    if (base != &PyBaseObject_Type ||
        (type->tp_flags & Py_TPFLAGS_HEAPTYPE)) {
        if (type->tp_new == NULL)
            type->tp_new = base->tp_new;
    }

msg391905 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 12:10

The explaining comment was added in f884b749103bad0724e2e4878cd5fe49a41bd7df.

The code itself is much older. It was originally added in 6d6c1a35e08b95a83dbe47dbd9e6474daff00354, then weaked in c11e192d416e2970e6a06cf06d4cf788f322c6ea and strengthen in 29687cd2112c540a8a4d31cf3b191cf10db08412.

All types except static types which are direct descendants of object inherit tp_new from a base class.

We need to check which static types had tp_new = NULL before they were converted to heap types and set it to NULL manually after type creation.

msg391909 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 12:33

We need to check which static types had tp_new = NULL before they were converted to heap types

I did a quick git grep. Results pasted into the list over at https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403.

msg391910 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 12:45

It is incomplete. For example arrayiterator did have tp_new = NULL (in other words, PyArrayIter_Type.tp_new was not set to non-NULL value).

In 3.9:

import array type(iter(array.array('I')))() Traceback (most recent call last): File "", line 1, in TypeError: cannot create 'arrayiterator' instances

In 3.10:

import array type(iter(array.array('I')))() <array.arrayiterator object at 0x7f02f88db5c0>

msg391911 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 12:48

It is incomplete.

Yes, I know. I'm working on completing it manually. Some of the static structs were only partially initialised (most stop at tp_members). The rest of the struct (including tp_new) would then be initialised to zero.

msg391912 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 12:50

Thank you for your work Erlend.

msg391913 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-26 12:51

Serhiy, do you think this should be a release blocker for the beta?

msg391917 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 13:06

Thank you for your work Erlend.

Anytime! I've updated the list now. There may still be errors, but I think it's pretty accurate now.

msg391924 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 13:24

Here's a plaintext version:

msg391925 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 13:30

Is there any way we can fix this in Objects/typeobject.c, or do we actually have to patch every single type manually?

msg391926 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-26 13:36

Is there any way we can fix this in Objects/typeobject.c, or do we actually have to patch every single type manually?

That would be probably a bad idea since typeobject.c is supposed to be generic. We would be inverting the responsibility concerns to the base.

msg391928 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 13:38

I afraid that changing the corresponding code in Objects/typeobject.c will break existing user code. For now, it is safer to patch every single type manually. Later we can design a general solution.

msg391929 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-26 13:40

I am marking this as a release blocker, giving that this is probably going to involve a big change.

msg391931 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 13:43

Is it worth it adding tests for this? I'm thinking a generic version of (maybe Lib/test/test_uninitialised_heap_types.py) coupled with a dataset.

msg391934 - (view)

Author: Christian Heimes (christian.heimes) * (Python committer)

Date: 2021-04-26 13:47

I have had this workaround in _hashopenssl.c for a while. Can I get rid of the function with "{Py_tp_new, NULL}" or is there a more generic way to accomplish the same goal?

/* {Py_tp_new, NULL} doesn't block new */ static PyObject * _disabled_new(PyTypeObject *type, PyObject *args, PyObject *kwargs) { PyErr_Format(PyExc_TypeError, "cannot create '%.100s' instances", _PyType_Name(type)); return NULL; }

msg391936 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-26 13:52

test_uninitialised_heap_types.py will need to import unrelited modules (some of which can be platform depending). And more modules will be added as more types be converted. I think it is better to add tests for different modules in corresponding module test files. They are pretty trivial, for example:

def test_new_tcl_obj(self):
    self.assertRaises(TypeError, _tkinter.Tcl_Obj)

@requires_curses_func('panel')
def test_new_curses_panel(self):
    w = curses.newwin(10, 10)
    panel = curses.panel.new_panel(w)
    self.assertRaises(TypeError, type(panel))

msg391937 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 13:56

You're right, that would become messy. Complementing existing test suites is a better approach.

msg391984 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 20:30

Christian:

Can I get rid of the function with "{Py_tp_new, NULL}" [...]

Unfortunately not. The workaround in 993e88cf08994f7c1e0f9f62fda4ed32634ee2ad does the trick though.

msg391992 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-26 22:12

Pablo, I've made a patch for most of these (I've left out Christian's modules). I've only added a couple of tests for now. Do you want all in one PR?

$ git diff main --stat
Lib/test/test_array.py | 4 ++++ Lib/test/test_unicodedata.py | 4 ++++ Modules/_dbmmodule.c | 1 + Modules/_functoolsmodule.c | 2 ++ Modules/_gdbmmodule.c | 1 + Modules/_sre.c | 5 +++++ Modules/_threadmodule.c | 2 ++ Modules/_winapi.c | 1 + Modules/arraymodule.c | 1 + Modules/cjkcodecs/multibytecodec.c | 1 + Modules/posixmodule.c | 2 ++ Modules/pyexpat.c | 1 + Modules/unicodedata.c | 1 + Modules/zlibmodule.c | 2 ++ 14 files changed, 28 insertions(+)

I don't know why I included the sqlite3 and select types in ; they are not affected by this issue. Somebody should double check that everything's covered.

msg391999 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-26 23:32

Pablo, I've made a patch for most of these (I've left out Christian's modules). I've only added a couple of tests for now. Do you want all in one PR?

Yes, please. The second most important part here is also adding regression tests so this doesn't happen. These tests should also be added when new types are converted in the future.

msg392036 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-27 07:26

These tests should also be added when new types are converted in the future.

We should have a checklist for static to heap type conversion. I'm pretty sure I've seen something like that in one of Victor's blogs. A new section in the Dev Guide, maybe?

msg392040 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-27 08:23

Alternative approach:

Add _PyType_DisabledNew to Include/cpython, and add {Py_tp_new, _PyType_DisabledNew} slot to affected types. Diff attached.

See GH discussion:

msg392042 - (view)

Author: Christian Heimes (christian.heimes) * (Python committer)

Date: 2021-04-27 08:30

LGTM

msg392044 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-27 08:36

Alternatively we can make PyType_FromSpec() setting tp_new to NULL if there is explicit {Py_tp_new, NULL} in slots.

msg392046 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-27 08:41

Alternatively we can make PyType_FromSpec() setting tp_new to NULL if there is explicit {Py_tp_new, NULL} in slots.

Yes. It's not as explicit (and self-documenting) as _PyType_DisabledNew, though. But it avoids expanding the C API.

msg392048 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-27 08:58

For that to work, you'd have to add a flag in PyType_FromModuleAndSpec, set the flag if (slot->slot == Py_tp_new && slot->pfunc == NULL) in the slots for loop, and then reset tp_new after PyType_Ready.

msg392057 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-27 11:53

The second most important part here is also adding regression tests so this doesn't happen.

I've started adding tests. I'm not sure if I need to wrap them with @cpython_only.

Some of the types are hidden deep inside the implementations, and I have a hard time fetching them. For example _functools._lru_list_elem and _thread._localdummy. Is it ok to leave those out?

msg392169 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-04-28 07:19

Is it ok to skip tests if it is too hard to write them.

Tests should be decorated with @cpython_only because other Python implementations can have working constructors for these types. It is an implementation detail that these types are implemented in C and instances are not properly initialized by default.

msg392170 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-28 07:20

Thanks, Serhiy.

msg392297 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-29 09:54

Serhiy, would you mind reviewing the PR? bpo-43974 will clean up the changes introduced to setup.py.

msg392414 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 10:46

New changeset 3bb09947ec4837de75532e21dd4bd25db0a1f1b7 by Victor Stinner in branch 'master': bpo-43916: Add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag (GH-25721) https://github.com/python/cpython/commit/3bb09947ec4837de75532e21dd4bd25db0a1f1b7

msg392426 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 12:07

New changeset 0cad068ec174bbe33fb80460da56eb413f3b9359 by Victor Stinner in branch 'master': bpo-43916: Remove _disabled_new() function (GH-25745) https://github.com/python/cpython/commit/0cad068ec174bbe33fb80460da56eb413f3b9359

msg392427 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 12:56

New changeset 4908fae3d57f68694cf006e89fd7761f45003447 by Victor Stinner in branch 'master': bpo-43916: PyStdPrinter_Type uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25749) https://github.com/python/cpython/commit/4908fae3d57f68694cf006e89fd7761f45003447

msg392433 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 13:49

New changeset 387397f8a4244c983f4568c16a28842e3268fe5d by Erlend Egeberg Aasland in branch 'master': bpo-43916: select.poll uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25750) https://github.com/python/cpython/commit/387397f8a4244c983f4568c16a28842e3268fe5d

msg392434 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 14:05

New changeset 9746cda705decebc0ba572d95612796afd06dcd4 by Erlend Egeberg Aasland in branch 'master': bpo-43916: Apply Py_TPFLAGS_DISALLOW_INSTANTIATION to selected types (GH-25748) https://github.com/python/cpython/commit/9746cda705decebc0ba572d95612796afd06dcd4

msg392435 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-30 14:10

Pablo & Serhiy, can we close this issue now?

msg392437 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 14:12

Currently, 33 types explicitly set the Py_TPFLAGS_DISALLOW_INSTANTIATION flag:

Static types with tp_base=NULL (or tp_base=&PyBaseObject_Type) and tp_new=NULL get Py_TPFLAGS_DISALLOW_INSTANTIATION flag automatically. Example of 70 static types which gets this flag automatically:

msg392438 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 14:13

I remove the release blocker priority of this issue, since the main issue has been fixed.

msg392451 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 15:47

According to , more types should use Py_TPFLAGS_DISALLOW_INSTANTIATION:

msg392456 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 16:00

I created PR 25753.

msg392462 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 16:05

It seems like _sqlite3 heap types support regular instantiation and so that no change is needed.

$ ./python Python 3.10.0a7+

import _sqlite3 conn=_sqlite3.Connection(":memory:")

type(conn)() TypeError: function missing required argument 'database' (pos 1) conn2 = type(conn)(":memory:")

list(conn.execute("SELECT 1;")) [(1,)] list(conn2.execute("SELECT 1;")) [(1,)]

msg392464 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 16:20

New changeset 7dcf0f6db38b7ab6918608542d3a0c6da0a286af by Victor Stinner in branch 'master': bpo-43916: select.devpoll uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25751) https://github.com/python/cpython/commit/7dcf0f6db38b7ab6918608542d3a0c6da0a286af

msg392465 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-30 16:20

Yes, the sqlite3 types are fine. I don't know why I included them in my earlier post.

I cleared the tp_new markings for the sqlite3 types on the Discourse post, since I can edit my posts over there, contrary to here on bpo :)

msg392472 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 16:40

New changeset 665c7746fca180266b121183c2d5136c547006e0 by Victor Stinner in branch 'master': bpo-43916: _md5.md5 uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25753) https://github.com/python/cpython/commit/665c7746fca180266b121183c2d5136c547006e0

msg392473 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 16:41

bpo-43916: _md5.md5 uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25753)

With this change, all tests listed in this issue should be fixed.

But I didn't check the whole list of https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403

msg392526 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 22:40

Status in Python 3.9.

5 types allow instantiation whereas they must not: BUG!!!

Example of bug:

$ python3.9 Python 3.9.4

import zlib obj=zlib.compressobj() obj2=type(obj)() obj2.copy() Erreur de segmentation (core dumped)

The remaining types disallow instantiation with different ways.

Static type with tp_base=NULL and tp_new=NULL:

Heap type setting tp_new to NULL after type creation:

Static type setting tp_new to NULL after type creation:

Define a tp_new or tp_init function which always raise an exception:

msg392528 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 22:42

Oops, sorry: in Python 3.9, tp_new is set to NULL after these heap types are created. There is no bug for these 3 types.

msg392534 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-04-30 23:00

I checked " Types converted pre Python 3.9" and "Types converted in Python 3.9" of: https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403

(I didn't check "Types converted in Python 3.10" yet.)

These lists are not complete, for example select.kevent was not listed whereas it has a bug.

_struct.unpack_iterator can be modified to use Py_TPFLAGS_DISALLOW_INSTANTIATION: its tp_new method always raises an exception.

Bugs!

Need review:

Implement tp_new (ok!):

Other cases (ok!):

msg392537 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-04-30 23:10

These lists are not complete, for example select.kevent was not listed whereas it has a bug.

If one of the admins could make that post into a wiki post, it would be open for editing, making it easier to fill the holes in the lists.

msg392545 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-30 23:39

If one of the admins could make that post into a wiki post, it would be open for editing, making it easier to fill the holes in the lists.

Not sure what do you have in mind for the wiki, but the easiest is to open some GitHub issue somewhere or using https://discuss.python.org/

msg392546 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-04-30 23:43

I think this is fine since ast_type_init doesn't initialize any C fields and only mutates the object by using PyObject_SetAttr

msg392553 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 00:43

Something is wrong after commit 3bb09947ec4837de75532e21dd4bd25db0a1f1b7.

When building Python I am getting:

*** WARNING: renaming "_curses" since importing it failed: /home/pablogsal/github/python/master/build/lib.linux-x86_64-3.10-pydebug/_curses.cpython-310d-x86_64-linux-gnu.so: undefined symbol: _PyStructSequence_InitType *** WARNING: renaming "_curses_panel" since importing it failed: No module named '_curses'

msg392554 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 00:48

The problem is that the curses module is using a function that requires to be built in the core:

#ifdef Py_BUILD_CORE extern int _PyStructSequence_InitType( PyTypeObject *type, PyStructSequence_Desc *desc, unsigned long tp_flags); #endif

msg392556 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 00:55

The build errors were in the CI, but because Python doesn't complain if it cannot build a module, then we never catched this. I have opened https://github.com/python/cpython/pull/25768 to fix it to unblock the release, since the curses module is broken currently.

msg392558 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 01:21

New changeset 558df9010915c8fe94f4d7f842e7c5aabbb06b14 by Pablo Galindo in branch 'master': bpo-43916: Export the _PyStructSequence_InitType to fix build errors in the curses module (GH-25768) https://github.com/python/cpython/commit/558df9010915c8fe94f4d7f842e7c5aabbb06b14

msg392570 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-05-01 05:15

Not sure what do you have in mind for the wiki

See https://meta.discourse.org/t/what-is-a-wiki-post/30801

msg392621 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 19:25

See https://meta.discourse.org/t/what-is-a-wiki-post/30801

Gotcha, will try to do that as soon as possible

msg392632 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-01 20:33

I have transformed https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403 into a wiki. Tell me if you need some alterations of something is missing.

msg392635 - (view)

Author: Christian Heimes (christian.heimes) * (Python committer)

Date: 2021-05-01 20:42

New changeset ddbef71a2c166a5d5dd168e26493973053a953d6 by Christian Heimes in branch 'master': bpo-43916: Rewrite new hashlib tests, fix typo (GH-25791) https://github.com/python/cpython/commit/ddbef71a2c166a5d5dd168e26493973053a953d6

msg392811 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-03 14:50

New changeset c2931d31f8ba7cf10044de276018c713ffc73592 by Pablo Galindo in branch 'master': bpo-43916: Move the _PyStructSequence_InitType function to the internal API (GH-25854) https://github.com/python/cpython/commit/c2931d31f8ba7cf10044de276018c713ffc73592

msg394571 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-05-27 17:07

Erlend added test.support.check_disallow_instantiation() function in bpo-43988 to write tests for immutable types.

msg394582 - (view)

Author: Pablo Galindo Salgado (pablogsal) * (Python committer)

Date: 2021-05-27 18:31

Please, check also the discusion happening here:

https://mail.python.org/archives/list/python-committers@python.org/thread/FHFI7QKWNHAVWVFTCHJGTYD3ZFVEUXDD/

msg394603 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-05-27 21:00

New changeset e90e0422182f4ca7faefd19c629f84aebb34e2ee by Erlend Egeberg Aasland in branch 'main': bpo-43916: Use test.support.check_disallow_instantiation() in test_tcl (GH-26412) https://github.com/python/cpython/commit/e90e0422182f4ca7faefd19c629f84aebb34e2ee

msg396200 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2021-06-20 21:01

FYI, bpo-44087 added the Py_TPFLAGS_DISALLOW_INSTANTIATION flag to sqlite3.Statement.

(Side note: I find the issue title a little bit confusing.)

msg396476 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2021-06-24 12:12

New changeset 733587011dbb47c2e461188f0574e1cc5288062a by Miss Islington (bot) in branch '3.10': bpo-43916: Use test.support.check_disallow_instantiation() in test_tcl (GH-26412) (GH-26888) https://github.com/python/cpython/commit/733587011dbb47c2e461188f0574e1cc5288062a

msg411785 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2022-01-26 17:51

In Python 3.11, 41 types are declared explicitly with the Py_TPFLAGS_DISALLOW_INSTANTIATION flag:

msg411786 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2022-01-26 18:01

Can we close this issue? Or is there a remaining task?

msg411865 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2022-01-27 13:12

Can we close this issue? Or is there a remaining task?

3.9 is still affected; we should fix those types first.

msg411867 - (view)

Author: Erlend E. Aasland (erlendaasland) * (Python triager)

Date: 2022-01-27 13:15

FYI: There are only two bug-fix releases left for 3.9.

msg411874 - (view)

Author: STINNER Victor (vstinner) * (Python committer)

Date: 2022-01-27 13:51

3.9 is still affected; we should fix those types first.

I'm against backporting the new type flag, but we can try to set explicitly tp_set to NULL after calling PyType_Ready().

History

Date

User

Action

Args

2022-04-11 14:59:44

admin

set

github: 88082

2022-01-27 13:51:31

vstinner

set

messages: +

2022-01-27 13:15:12

erlendaasland

set

messages: +

2022-01-27 13:13:27

erlendaasland

set

title: Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag -> Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2022-01-27 13:12:27

erlendaasland

set

versions: + Python 3.9, - Python 3.10

2022-01-27 13:12:19

erlendaasland

set

messages: +

2022-01-26 18:01:28

vstinner

set

messages: +

2022-01-26 17:51:14

vstinner

set

messages: +

2021-06-24 12:12:15

vstinner

set

messages: +

2021-06-24 07:40:55

miss-islington

set

nosy: + miss-islington
pull_requests: + <pull%5Frequest25465>

2021-06-20 21:01:25

erlendaasland

set

messages: +

2021-05-27 21:00:29

vstinner

set

messages: +

2021-05-27 18:31:36

pablogsal

set

messages: +

2021-05-27 18:08:45

erlendaasland

set

pull_requests: + <pull%5Frequest25006>

2021-05-27 17:07:26

vstinner

set

messages: +

2021-05-03 14:50:30

pablogsal

set

messages: +

2021-05-03 14:34:20

pablogsal

set

pull_requests: + <pull%5Frequest24538>

2021-05-01 20:42:42

christian.heimes

set

messages: +

2021-05-01 20:33:00

pablogsal

set

messages: +

2021-05-01 19:52:38

christian.heimes

set

pull_requests: + <pull%5Frequest24480>

2021-05-01 19:25:53

pablogsal

set

messages: +

2021-05-01 05:15:46

erlendaasland

set

messages: +

2021-05-01 01:21:26

pablogsal

set

messages: +

2021-05-01 00:55:26

pablogsal

set

messages: +

2021-05-01 00:55:04

pablogsal

set

pull_requests: + <pull%5Frequest24461>

2021-05-01 00:48:58

pablogsal

set

messages: +

2021-05-01 00:43:12

pablogsal

set

messages: +

2021-04-30 23:43:42

pablogsal

set

messages: +

2021-04-30 23:39:44

pablogsal

set

messages: +

2021-04-30 23:10:58

erlendaasland

set

messages: +

2021-04-30 23:00:50

vstinner

set

messages: +

2021-04-30 22:42:22

vstinner

set

messages: +

2021-04-30 22:40:43

vstinner

set

messages: +

2021-04-30 16:41:21

vstinner

set

messages: +

2021-04-30 16:40:38

vstinner

set

messages: +

2021-04-30 16:20:59

erlendaasland

set

messages: +

2021-04-30 16:20:01

vstinner

set

messages: +

2021-04-30 16:05:08

vstinner

set

messages: +

2021-04-30 16:00:10

vstinner

set

messages: +

2021-04-30 15:58:07

vstinner

set

pull_requests: + <pull%5Frequest24443>

2021-04-30 15:47:23

vstinner

set

messages: +

2021-04-30 15:46:32

vstinner

set

pull_requests: + <pull%5Frequest24441>

2021-04-30 14:13:31

vstinner

set

priority: release blocker ->

messages: +

2021-04-30 14:12:51

vstinner

set

messages: +

2021-04-30 14:10:23

erlendaasland

set

messages: +

2021-04-30 14:05:04

vstinner

set

messages: +

2021-04-30 13:49:24

vstinner

set

messages: +

2021-04-30 13:26:53

erlendaasland

set

pull_requests: + <pull%5Frequest24439>

2021-04-30 12:56:30

vstinner

set

messages: +

2021-04-30 12:31:04

vstinner

set

pull_requests: + <pull%5Frequest24438>

2021-04-30 12:15:21

erlendaasland

set

pull_requests: + <pull%5Frequest24437>

2021-04-30 12:07:06

vstinner

set

messages: +

2021-04-30 11:02:24

vstinner

set

pull_requests: + <pull%5Frequest24434>

2021-04-30 10:52:57

vstinner

set

components: + C API

2021-04-30 10:52:47

vstinner

set

title: Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag -> Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 10:52:14

vstinner

set

title: Check that new heap types cannot be created uninitialised -> Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 10:46:19

vstinner

set

messages: +

2021-04-29 21:53:30

vstinner

set

pull_requests: + <pull%5Frequest24424>

2021-04-29 15:58:41

christian.heimes

set

pull_requests: + <pull%5Frequest24413>

2021-04-29 15:37:04

vstinner

set

pull_requests: + <pull%5Frequest24412>

2021-04-29 09:54:26

erlendaasland

set

messages: +

2021-04-28 07:20:36

erlendaasland

set

messages: +

2021-04-28 07:19:21

serhiy.storchaka

set

messages: +

2021-04-27 11:53:09

erlendaasland

set

messages: +

2021-04-27 08:58:32

erlendaasland

set

messages: +

2021-04-27 08:41:25

erlendaasland

set

messages: +

2021-04-27 08:36:52

serhiy.storchaka

set

messages: +

2021-04-27 08:30:34

christian.heimes

set

messages: +

2021-04-27 08:23:03

erlendaasland

set

files: + disablednew.diff

messages: +

2021-04-27 07:26:17

erlendaasland

set

messages: +

2021-04-27 07:20:32

erlendaasland

set

stage: patch review
pull_requests: + <pull%5Frequest24344>

2021-04-26 23:32:56

pablogsal

set

messages: +

2021-04-26 22:13:03

erlendaasland

set

files: + patch.diff
keywords: + patch

2021-04-26 22:12:19

erlendaasland

set

messages: +

2021-04-26 20:30:19

erlendaasland

set

messages: +

2021-04-26 13:56:04

erlendaasland

set

messages: +

2021-04-26 13:52:27

serhiy.storchaka

set

messages: +

2021-04-26 13:47:31

christian.heimes

set

nosy: + christian.heimes
messages: +

2021-04-26 13:43:59

erlendaasland

set

messages: +

2021-04-26 13:40:10

pablogsal

set

priority: deferred blocker -> release blocker

messages: +

2021-04-26 13:38:40

serhiy.storchaka

set

messages: +

2021-04-26 13:36:35

pablogsal

set

messages: +

2021-04-26 13:30:13

erlendaasland

set

messages: +

2021-04-26 13:24:42

erlendaasland

set

messages: +

2021-04-26 13:06:14

erlendaasland

set

messages: +

2021-04-26 12:51:13

pablogsal

set

messages: +

2021-04-26 12:50:39

serhiy.storchaka

set

messages: +

2021-04-26 12:48:39

erlendaasland

set

messages: +

2021-04-26 12:45:25

serhiy.storchaka

set

messages: +

2021-04-26 12:33:26

erlendaasland

set

messages: +

2021-04-26 12:10:44

serhiy.storchaka

set

messages: +

2021-04-26 11:54:22

shreyanavigyan

set

nosy: + shreyanavigyan

2021-04-26 11:48:11

serhiy.storchaka

set

messages: +

2021-04-26 11:31:25

erlendaasland

set

nosy: + erlendaasland

2021-04-22 21:32:34

pablogsal

set

messages: +

2021-04-22 21:31:58

pablogsal

create