bpo-43916: Add _PyType_DisabledNew to prevent new heap types from being created uninitialised by erlend-aasland · Pull Request #25653 · python/cpython (original) (raw)

@pablogsal, @vstinner: I've marked this as ready for review. Test coverage is not complete, but I'm not sure how much time we should put into extracting all the implementation specific types; they are normally hidden from the APIs anyway, and one really has to put an effort into snatching the type and then trying to create it uninitialised. Consenting adults and so on.

I refer to Pablos's comment regarding my problems with declaring _PyType_DisabledNew using extern: #25653 (comment)

@tiran will take care of his stuff, presumably in a separate PR.

I still think the PR is too large, but that's up to you two to decide :)

BTW, _tkinter fails because Py_BUILD_CORE is not set on Travis; I'll have a look at setup.py and Modules/Setup. UPDATE: Fixed in ce16da5