Fixing build errors with CI by Arlodotexe · Pull Request #31 · CommunityToolkit/ColorCode-Universal (original) (raw)

Arlodotexe commented

Oct 24, 2022

•

edited

Loading

Copy link Copy Markdown

Member

This PR attempts to fix the CI errors occurring on the main branch (previously #29)

Arlodotexe added 2 commits

October 24, 2022 18:49

[Swap cake for direct msbuild invocation](/CommunityToolkit/ColorCode-Universal/pull/31/commits/66c49b1e09ceff072a9725594644c354dc6b3e7d "Swap cake for direct msbuild invocation")

[66c49b1](/CommunityToolkit/ColorCode-Universal/pull/31/commits/66c49b1e09ceff072a9725594644c354dc6b3e7d)

[Use manual shell invocation task for msbuild](/CommunityToolkit/ColorCode-Universal/pull/31/commits/61d190cbd342b001a56ef9e87ea01511ed500260 "Use manual shell invocation task for msbuild")

[61d190c](/CommunityToolkit/ColorCode-Universal/pull/31/commits/61d190cbd342b001a56ef9e87ea01511ed500260)

michael-hawker linked an issue

Oct 25, 2022

that may beclosed by this pull request

Issue with ColorCode Build#28

Closed

Arlodotexe added 3 commits

October 25, 2022 16:09

[Copy nupkg to single folder before publishing artifacts](/CommunityToolkit/ColorCode-Universal/pull/31/commits/41896bde6e0d67276265c5e1f296399d3a314597 "Copy nupkg to single folder before publishing artifacts")

[41896bd](/CommunityToolkit/ColorCode-Universal/pull/31/commits/41896bde6e0d67276265c5e1f296399d3a314597)

[Enable folder flattening when copying files](/CommunityToolkit/ColorCode-Universal/pull/31/commits/fc5e779fb70935b3df5e9f2751b95e274aa5b56f "Enable folder flattening when copying files")

[fc5e779](/CommunityToolkit/ColorCode-Universal/pull/31/commits/fc5e779fb70935b3df5e9f2751b95e274aa5b56f)

[Only include ColorCode nupkg files](/CommunityToolkit/ColorCode-Universal/pull/31/commits/8e770355cb58d0249e421693fac8cbc116ec0d07 "Only include ColorCode nupkg files")

[8e77035](/CommunityToolkit/ColorCode-Universal/pull/31/commits/8e770355cb58d0249e421693fac8cbc116ec0d07)

Arlodotexe commented

Oct 25, 2022

•

edited

Loading

Copy link Copy Markdown

Member Author

@michael-hawker We should be good to go on this after I remove cake.

Arlodotexe requested a review from michael-hawker

October 25, 2022 21:55

Arlodotexe added 3 commits

October 25, 2022 16:57

[Removed cake](/CommunityToolkit/ColorCode-Universal/pull/31/commits/b67b4bbf7f370b80082fe266b5d187060e85244e "Removed cake")

[b67b4bb](/CommunityToolkit/ColorCode-Universal/pull/31/commits/b67b4bbf7f370b80082fe266b5d187060e85244e)

`[Revert "Removed cake"](/CommunityToolkit/ColorCode-Universal/pull/31/commits/cd4cea10109ca372ad2b5c12d1ac77a492ea70bc "Revert "Removed cake"

This reverts commit b67b4bbf7f370b80082fe266b5d187060e85244e.") `

[cd4cea1](/CommunityToolkit/ColorCode-Universal/pull/31/commits/cd4cea10109ca372ad2b5c12d1ac77a492ea70bc)

This reverts commit b67b4bb.

[Removed cake tooling](/CommunityToolkit/ColorCode-Universal/pull/31/commits/0e37bb3ab6b603fc58bd296c5f528915fa9c7ed4 "Removed cake tooling")

[0e37bb3](/CommunityToolkit/ColorCode-Universal/pull/31/commits/0e37bb3ab6b603fc58bd296c5f528915fa9c7ed4)

michael-hawker requested changes Oct 25, 2022

View reviewed changes

michael-hawker left a comment •

edited

Loading

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but looks like it's building now 🎉, so will check the artifacts after the revision.

Comment thread

build/build.cake

Comment thread

azure-pipelines.yml Outdated

Comment thread

build/build.cake

Arlodotexe added 2 commits

October 26, 2022 18:48

[Use PackageOutputPath instead of copying files](/CommunityToolkit/ColorCode-Universal/pull/31/commits/0db139e4e0aba7e5f4c3e7ae3b1e8254e2a2ca44 "Use PackageOutputPath instead of copying files")

[0db139e](/CommunityToolkit/ColorCode-Universal/pull/31/commits/0db139e4e0aba7e5f4c3e7ae3b1e8254e2a2ca44)

[Use .editorconfig for file headers](/CommunityToolkit/ColorCode-Universal/pull/31/commits/37c0244a88ab7e0ccfce55a412f2ef9c54d9241a "Use .editorconfig for file headers")

[37c0244](/CommunityToolkit/ColorCode-Universal/pull/31/commits/37c0244a88ab7e0ccfce55a412f2ef9c54d9241a)

michael-hawker approved these changes Oct 27, 2022

View reviewed changes

michael-hawker commented

Oct 27, 2022

Copy link Copy Markdown

Member

Thanks @Arlodotexe!

michael-hawker merged commit d21df72 into CommunityToolkit:main

Oct 27, 2022

Arlodotexe deleted the fix/ci-errors branch

February 1, 2024 22:30

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})