Always initialise display->gl_context before it's used by metayan · Pull Request #5058 · Genymobile/scrcpy (original) (raw)

Otherwise SDL_GL_DeleteContext tried to access an uninitialised pointer upon exit when not using the OpenGL renderer.

SDL_GL_DeleteContext doesn't try to delete a NULL pointer, so no need to check for that.

@rom1v changed the base branch from master to dev

July 5, 2024 07:26

rom1v pushed a commit that referenced this pull request

Jul 5, 2024

@rom1v

Otherwise SDL_GL_DeleteContext() tried to access an uninitialized pointer upon exit when not using the OpenGL renderer.

SDL_GL_DeleteContext() doesn't try to delete a NULL pointer, so no need to check for that.

Fixes #5057 <#5057> PR #5058 <#5058>

Signed-off-by: Romain Vimont rom@rom1v.com

FreedomBen pushed a commit to FreedomBen/scrcpy that referenced this pull request

Aug 2, 2024

@FreedomBen

Otherwise SDL_GL_DeleteContext() tried to access an uninitialized pointer upon exit when not using the OpenGL renderer.

SDL_GL_DeleteContext() doesn't try to delete a NULL pointer, so no need to check for that.

Fixes Genymobile#5057 <Genymobile#5057> PR Genymobile#5058 <Genymobile#5058>

Signed-off-by: Romain Vimont rom@rom1v.com

Gottox pushed a commit to Gottox/scrcpy that referenced this pull request

Sep 29, 2024

@Gottox

Otherwise SDL_GL_DeleteContext() tried to access an uninitialized pointer upon exit when not using the OpenGL renderer.

SDL_GL_DeleteContext() doesn't try to delete a NULL pointer, so no need to check for that.

Fixes Genymobile#5057 <Genymobile#5057> PR Genymobile#5058 <Genymobile#5058>

Signed-off-by: Romain Vimont rom@rom1v.com

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

Otherwise SDL_GL_DeleteContext() tried to access an uninitialized pointer upon exit when not using the OpenGL renderer.

SDL_GL_DeleteContext() doesn't try to delete a NULL pointer, so no need to check for that.

Fixes Genymobile#5057 <Genymobile#5057> PR Genymobile#5058 <Genymobile#5058>

Signed-off-by: Romain Vimont rom@rom1v.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})