Enable workarounds by default by rom1v · Pull Request #5154 · Genymobile/scrcpy (original) (raw)
This was referenced
Jul 30, 2024
added a commit that referenced this pull request
Workarounds were disabled by default, and enabled only on some device or in specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices 1. But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices 2, but it seems this is not the case anymore 3.
They might also impact an old Nvidia Shield 4, but hopefully this is fixed now.
[WIP] Enable workarounds by default Enable workarounds by default
Workarounds were disabled by default, and only enabled for some devices or under specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices 1. But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices 2, but it seems this is not the case anymore 3.
They might also impact an old Nvidia Shield 4, but hopefully this is fixed now.
FreedomBen pushed a commit to FreedomBen/scrcpy that referenced this pull request
Workarounds were disabled by default, and only enabled for some devices or under specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices 1. But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices 2, but it seems this is not the case anymore 3.
They might also impact an old Nvidia Shield 4, but hopefully this is fixed now.
PR Genymobile#5154 <Genymobile#5154>
Gottox pushed a commit to Gottox/scrcpy that referenced this pull request
Workarounds were disabled by default, and only enabled for some devices or under specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices 1. But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices 2, but it seems this is not the case anymore 3.
They might also impact an old Nvidia Shield 4, but hopefully this is fixed now.
PR Genymobile#5154 <Genymobile#5154>
bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request
Workarounds were disabled by default, and only enabled for some devices or under specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception to be printed on some Xiaomi devices 1. But this is not a problem anymore since commit b8c5853.
They also caused problems for audio on Vivo devices 2, but it seems this is not the case anymore 3.
They might also impact an old Nvidia Shield 4, but hopefully this is fixed now.
PR Genymobile#5154 <Genymobile#5154>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})