Forward Alt and Super by rom1v · Pull Request #5322 · Genymobile/scrcpy (original) (raw)

This was referenced

Sep 27, 2024

added 3 commits

October 6, 2024 18:00

@rom1v

Alt and Super (also named Meta) modifier keys are captured for shortcuts by default (cf --shortcut-mod).

However, when shortcut modifiers are changed, Alt and Super should be forwarded to the device. This is the case for AOA and UHID keyboards, but it was not the case for SDK keyboard.

Fixes #5318 <#5318> PR #5322 <#5322>

@rom1v

Masking was unnecessary (im->sdl_shortcut_mods is implicitly masked).

PR #5322 <#5322>

@rom1v

Factorize mouse capture for relative mouse mode to reduce code duplication between normal and OTG modes.

PR #5322 <#5322>

@rom1v

This will allow to reuse it for mouse capture keys, which are handled by a component separate from the input manager.

PR #5322 <#5322>

@rom1v

Instead of using separate hardcoded keys for mouse capture/uncapture, use the shortcut mods.

By changing the shortcut mods (for example --shortcut-mod=rctrl), it allows to forward Alt and Super to the device.

Fixes #5318 <#5318> PR #5322 <#5322>

@rom1v rom1v mentioned this pull request

Oct 20, 2024

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

@rom1v

Alt and Super (also named Meta) modifier keys are captured for shortcuts by default (cf --shortcut-mod).

However, when shortcut modifiers are changed, Alt and Super should be forwarded to the device. This is the case for AOA and UHID keyboards, but it was not the case for SDK keyboard.

Fixes Genymobile#5318 <Genymobile#5318> PR Genymobile#5322 <Genymobile#5322>

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

@rom1v

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

@rom1v

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

@rom1v

This will allow to reuse it for mouse capture keys, which are handled by a component separate from the input manager.

PR Genymobile#5322 <Genymobile#5322>

bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request

Apr 11, 2025

@rom1v

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})