Only disable control for no-window if we also don't do any other video operations by samlii · Pull Request #5804 · Genymobile/scrcpy (original) (raw)
pushed a commit that referenced this pull request
Without a window, mouse and keyboard events may not be received, but the control channel is still necessary for other features:
- --turn-screen-off
- --stay-awake
- --show-touches
- --power-off-on-close
- --start-app
Fixes #5803 <#5803> PR #5804 <#5804>
rom1v pushed a commit that referenced this pull request
Without a window, mouse and keyboard events may not be received, but the control channel is still necessary for other features:
- --turn-screen-off
- --stay-awake
- --show-touches
- --power-off-on-close
- --start-app
Fixes #5803 <#5803> PR #5804 <#5804>
Signed-off-by: Romain Vimont rom@rom1v.com
rom1v pushed a commit that referenced this pull request
Without a window, mouse and keyboard events may not be received, but the control channel is still necessary for other features:
- --turn-screen-off
- --stay-awake
- --show-touches
- --power-off-on-close
- --start-app
Fixes #5803 <#5803> PR #5804 <#5804>
Signed-off-by: Romain Vimont rom@rom1v.com
Mr-JingShi pushed a commit to Mr-JingShi/scrcpy that referenced this pull request
Without a window, mouse and keyboard events may not be received, but the control channel is still necessary for other features:
- --turn-screen-off
- --stay-awake
- --show-touches
- --power-off-on-close
- --start-app
Fixes Genymobile#5803 <Genymobile#5803> PR Genymobile#5804 <Genymobile#5804>
Signed-off-by: Romain Vimont rom@rom1v.com
rom1v added a commit that referenced this pull request
Since #5804, controls have been enabled even with --no-window. As a result, the Android clipboard is synchronized with the computer, causing SDL to trigger an SDL_CLIPBOARDUPDATE event.
This event is ignored by scrcpy, but it was still transmitted to the sc_screen instance, even if it had not been initialized.
Fix the issue by calling sc_screen_handle_event() only when a screen instance exists.
Refs #5804 <#5804> Fixes #5970 <#5970>
bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request
Since Genymobile#5804, controls have been enabled even with --no-window. As a result, the Android clipboard is synchronized with the computer, causing SDL to trigger an SDL_CLIPBOARDUPDATE event.
This event is ignored by scrcpy, but it was still transmitted to the sc_screen instance, even if it had not been initialized.
Fix the issue by calling sc_screen_handle_event() only when a screen instance exists.
Refs Genymobile#5804 <Genymobile#5804> Fixes Genymobile#5970 <Genymobile#5970>
bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request
Without a window, mouse and keyboard events may not be received, but the control channel is still necessary for other features:
- --turn-screen-off
- --stay-awake
- --show-touches
- --power-off-on-close
- --start-app
Fixes Genymobile#5803 <Genymobile#5803> PR Genymobile#5804 <Genymobile#5804>
Signed-off-by: Romain Vimont rom@rom1v.com
bartsaintgermain pushed a commit to bartsaintgermain/scrcpy that referenced this pull request
Since Genymobile#5804, controls have been enabled even with --no-window. As a result, the Android clipboard is synchronized with the computer, causing SDL to trigger an SDL_CLIPBOARDUPDATE event.
This event is ignored by scrcpy, but it was still transmitted to the sc_screen instance, even if it had not been initialized.
Fix the issue by calling sc_screen_handle_event() only when a screen instance exists.
Refs Genymobile#5804 <Genymobile#5804> Fixes Genymobile#5970 <Genymobile#5970>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})