Migrate from SDL2 to SDL3 by rom1v · Pull Request #6216 · Genymobile/scrcpy (original) (raw)
rom1v added a commit that referenced this pull request
This improves consistency and will simplify further refactors.
The SDL3 migration guide 1 says:
The following window operations are now considered to be asynchronous requests and should not be assumed to succeed unless a corresponding event has been received […]
Remove the boolean fields used to track the window state, as they were fundamentally inconsistent with SDL's internal state. Use SDL_GetWindowFlags() explicitly instead.
Refs #6216 comment <#6216 (comment)> PR #6216 <#6216>
The Ubuntu version used to build scrcpy does not provide an SDL3 package.
Use BT.709 color space for AVCOL_SPC_RGB.
Refs #1868 comment <#1868 (comment)>
Signed-off-by: Romain Vimont rom@rom1v.com
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
The SDL3 migration guide 1 says:
The following window operations are now considered to be asynchronous requests and should not be assumed to succeed unless a corresponding event has been received […]
Remove the boolean fields used to track the window state, as they were fundamentally inconsistent with SDL's internal state. Use SDL_GetWindowFlags() explicitly instead.
Refs #6216 comment <Genymobile/scrcpy#6216 (comment)> PR #6216 <Genymobile/scrcpy#6216>
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
Jamilah-nabel pushed a commit to Jamilah-nabel/https-github.com-Genymobile-scrcpy that referenced this pull request
This was referenced
Jan 28, 2026
rom1v added a commit that referenced this pull request
Setting the window position can be denied, as observed in logs from 1:
ERROR: Could not set window position: wayland cannot position non-popup windowsAlso do not assume window size setting succeeds.
Refs #6216 comment <#6216 (comment)> PR #6802 <#6802>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})