Small SDL3 macOS fixes by metayan · Pull Request #6259 · Genymobile/scrcpy (original) (raw)

and others added 10 commits

July 17, 2025 18:35

@rom1v

@rom1v

Inline the function body in its only caller.

This will simplify further refactors.

@rom1v

The texture was created as soon as the initial video size was known, even before the first frame arrived.

However, texture creation will require other data, such as the color range, which is only available once the first frame is received.

Therefore, delay texture creation until the first frame.

@rom1v

This prepares for the migration to SDL3, where the color range can only be specified at the time of texture creation.

@rom1v

Use both the color space and color range from FFmpeg to determine the appropriate SDL YUV conversion mode.

@rom1v

@rom1v

@rom1v

The latest Ubuntu does not provide the SDL3 package yet.

@metayan metayan changed the base branch from master to sdl3

July 27, 2025 18:00

rom1v pushed a commit that referenced this pull request

Aug 12, 2025

@rom1v

The field gl_context is initialized from SDL_GL_CreateContext(), which returns a raw SDL_GLContext, not a pointer.

The type mismatch was silently ignored by SDL2 because SDL_GLContext was defined as an alias to void * (in SDL3, it is instead an alias to struct SDL_GLContextState *, so compilation fails).

Refs #3895 <#3895> PR #6259 <#6259>

Signed-off-by: Romain Vimont rom@rom1v.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})