feat: conditional gateway resource creation and customized section names by misba7 · Pull Request #13551 · JanssenProject/jans (original) (raw)
Caution
Review failed
The pull request is closed.
ℹ️ Recent review info ⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 776beff7-47d4-48fe-a8b3-0ceef05986b9
📥 Commits
Reviewing files that changed from the base of the PR and between 5c8ed0d and 02e38a7.
📒 Files selected for processing (4)
charts/janssen/charts/gateway-api/templates/gateway.yamlcharts/janssen/charts/gateway-api/templates/route.yamlcharts/janssen/charts/gateway-api/values.yamlcharts/janssen/values.yaml
📝 Walkthrough
Walkthrough
This PR modifies the gateway-api Helm subchart to conditionally create the Gateway resource and parameterize route-to-gateway associations. It introduces configuration options for gateway namespace and listener section names, enabling routes to attach to external gateways managed separately while maintaining backward compatibility.
Changes
| Cohort / File(s) | Summary |
|---|---|
| Gateway conditional rendering charts/janssen/charts/gateway-api/templates/gateway.yaml | Wrapped the Gateway manifest in a conditional if block that checks .Values.gateway.enabled, allowing the resource to be skipped when external gateway management is preferred. |
| Route parameterization charts/janssen/charts/gateway-api/templates/route.yaml | Introduced template variables for gateway namespace and listener section names ($gatewayNamespace, httpSection,httpSection, httpSection,httpsSection); updated HTTPRoute and GRPCRoute parentRefs to include namespace field and use parameterized section names instead of hardcoded values. |
| Gateway-api subchart values charts/janssen/charts/gateway-api/values.yaml | Added gateway.enabled flag (default true), routes.gatewayNamespace (default empty), routes.httpSectionName (default "http"), and routes.httpsSectionName (default "https") configuration options. |
| Parent chart values charts/janssen/values.yaml | Extended parent values with corresponding gateway-api configuration: gateway-api.gateway.enabled set to true by default, plus new routes scoping and section name parameters. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
- feat(cloud-native): add subchart for Gateway API conformant implementation #13415: Modifies the same gateway-api subchart templates and values with overlapping changes to Gateway and route rendering logic.
- feat(charts): support gateway api in janssen-aio #12907: Adds Gateway API support to Janssen Helm charts, addressing the same feature area across different chart variants.
Suggested reviewers
- iromli ✨ Finishing Touches 🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
jans-gateway-customization
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.