Skip HttpRequest duration check when DurationThresholdMs = Zero by snakefoot · Pull Request #1113 · NLog/NLog.Web (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

NLog / NLog.Web Public

Additional navigation options

Merged

snakefoot

merged 3 commits into

NLog:masterfrom

snakefoot:master

Dec 23, 2025

ConversationCommits (3)ChecksFiles changed

Merged

Skip HttpRequest duration check when DurationThresholdMs = Zero#1113

snakefoot

merged 3 commits into

NLog:masterfrom

snakefoot:master

Conversation

@snakefoot

@snakefoot snakefoot commented

Nov 17, 2025

edited

Loading

Copy link Copy Markdown

Contributor

Slow HttpRequest duration should not translate to "failure"

Downgrade LogLevel for OperationCanceledException when RequestAborted

@pull-request-size pull-request-size Bot added the size/S label

Nov 17, 2025

snakefoot added 2 commits

December 23, 2025 10:11

@snakefoot

[Skip HttpRequest duration check when DurationThresholdMs = Zero](/NLog/NLog.Web/pull/1113/commits/2e04ab318e52c36a26d04c7df98772129a424020 "Skip HttpRequest duration check when DurationThresholdMs = Zero")

[2e04ab3](/NLog/NLog.Web/pull/1113/commits/2e04ab318e52c36a26d04c7df98772129a424020)

@snakefoot

[Updated nuget README about fluent setup is not required](/NLog/NLog.Web/pull/1113/commits/36cb8580d82c7c50f2a3dd497e4f1bbb994d0177 "Updated nuget README about fluent setup is not required")

[36cb858](/NLog/NLog.Web/pull/1113/commits/36cb8580d82c7c50f2a3dd497e4f1bbb994d0177)

@pull-request-size pull-request-size Bot added size/M and removed size/S labels

Dec 23, 2025

@snakefoot snakefoot force-pushed the master branch from80b3324 to36cb858 Compare

December 23, 2025 09:12

@snakefoot

[Downgrade LogLevel for OperationCanceledException when RequestAborted](/NLog/NLog.Web/pull/1113/commits/fd993b26edcda85751e87d44fb1c3892b6e4f825 "Downgrade LogLevel for OperationCanceledException when RequestAborted")

[fd993b2](/NLog/NLog.Web/pull/1113/commits/fd993b26edcda85751e87d44fb1c3892b6e4f825)

@snakefoot snakefoot force-pushed the master branch from12ada54 tofd993b2 Compare

December 23, 2025 11:04

@sonarqubecloud

sonarqubecloud Bot commented

Dec 23, 2025

Copy link Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
61.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@snakefoot snakefoot merged commit 634154b into NLog:master

Dec 23, 2025

5 of 6 checks passed

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot