admonition extension returns invalid html code without blank line. · Issue #1329 · Python-Markdown/markdown (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Description

In [8]: import markdown In [9]: some_text = """ ...: !!! danger "Danger" ...: don't try this at home. ...: ...: """ In [10]: markdown.markdown(some_text, tab_length=2, extensions=['admonition']) Out[10]: '

1. A paragraph inside a paragraph is invalid html and etree parser complains!
2. the simple solution of turning the title paragraph into a div will work, but it wraps the inner paragraph, resulting in a CSS mess.

Recommended working solution:

 CLASSNAME_TITLE = 'admonition-title'

• CLASSNAME_BODY = 'admonition-body' RE = re.compile(r'(?:^|\n)!!! ?([\w-]+(?: +[\w-]+))(?: +"(.?)")? *(?:\n|$)')

@@ -130,9 +134,11 @@ class AdmonitionProcessor(BlockProcessor): div = etree.SubElement(parent, 'div') div.set('class', '{} {}'.format(self.CLASSNAME, klass)) if title:

•            p = etree.SubElement(div, 'p')

•            p = etree.SubElement(div, 'div')
             p.text = title
             p.set('class', self.CLASSNAME_TITLE)

•            p = etree.SubElement(div, 'div')

•            p.set('class', self.CLASSNAME_BODY)

Note: the parse_content() method of your admonition extension is an unreadable code-mess ;-)