SQLiteCpp/Statement.h: add missing <cstdint> include by trofi · Pull Request #488 · SRombauts/SQLiteCpp (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Without the change the build fails on gcc-15 as:

[  5%] Building CXX object CMakeFiles/SQLiteCpp.dir/src/Backup.cpp.o
In file included from /build/source/include/SQLiteCpp/Column.h:14,
                 from /build/source/include/SQLiteCpp/Database.h:14,
                 from /build/source/include/SQLiteCpp/Backup.h:15,
                 from /build/source/src/Backup.cpp:12:
/build/source/include/SQLiteCpp/Statement.h:132:39: error: 'uint32_t' does not name a type
  132 |     void bind(const int aIndex, const uint32_t      aValue);
      |                                       ^~~~~~~~
/build/source/include/SQLiteCpp/Statement.h:20:1: note: 'uint32_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
   19 | #include <memory>
  +++ |+#include <cstdint>
   20 |

Without the change the build fails on gcc-15 as:

[  5%] Building CXX object CMakeFiles/SQLiteCpp.dir/src/Backup.cpp.o
In file included from /build/source/include/SQLiteCpp/Column.h:14,
                 from /build/source/include/SQLiteCpp/Database.h:14,
                 from /build/source/include/SQLiteCpp/Backup.h:15,
                 from /build/source/src/Backup.cpp:12:
/build/source/include/SQLiteCpp/Statement.h:132:39: error: 'uint32_t' does not name a type
  132 |     void bind(const int aIndex, const uint32_t      aValue);
      |                                       ^~~~~~~~
/build/source/include/SQLiteCpp/Statement.h:20:1: note: 'uint32_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
   19 | #include <memory>
  +++ |+#include <cstdint>
   20 |

Thanks a lot for taking the time to contribute these two fixes, much appreciated

trofi deleted the gcc-15-add-cstdint branch

September 7, 2024 14:42

SRombauts added a commit that referenced this pull request

May 20, 2025

What's Changed

• Update SQLite from 3.46.1 to 3.49.2 (2025-05-07) by @SRombauts in #505
• Add a Github Dependabot config file by @SRombauts in #480
• Bump actions/checkout from 3 to 4 by @dependabot in #482
• Replace all double-quoted string literals by single quotes in unit test by @SRombauts in #483
• Use explicit versions of Ubuntu images instead of latest by @SRombauts in #484
• Test linking with builtin libsqlite3-dev package on Ubuntu by @SRombauts in #485
• Add logic to use different FindPackage for python if cmake is above 3.12 by @syntheticgio in #454
• tests/Database_test.cpp: fix a warning around #endif by @trofi in #489
• SQLiteCpp/Statement.h: add missing <cstdint> include by @trofi in #488
• sqlite3: set SQLITE_OMIT_LOAD_EXTENSION by @brt-v in #496
• Update googletest to v1.16.0 by @SRombauts in #506
• update meson dependencies by @UnixY2K in #508

New Contributors

• @syntheticgio made their first contribution in #454
• @trofi made their first contribution in #489
• @brt-v made their first contribution in #496

Full Changelog: 3.3.2...3.3.3

2 participants