List requested matches for bot authors in their profile page and allow cancellations by Immodal · Pull Request #142 · aiarena/aiarena-web (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits3 Checks0 Files changed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- Requested matches appear on User Profile.
- User can cancel matches requested by them from their profile page.
- Only matches that haven't been assigned to an arena client can be cancelled.
- On success or failure, a message will display at the top of the page.
- Right now only matches cancelled by them will refund their match requests.
@lladdy @eladyaniv01
I'm not sure if the way I implemented it is the best way to do it, do let me know if you can think of how to improve it.
- User can cancel matches requested by them from their profile page.
- Only matches that haven't been assigned to an arena client can be cancelled.
- On success or failure, a message will display at the top of the page.
- Right now only matches cancelled by them will refund their match requests
Looking good @Immodal,
could you please add a simple unit test that ensures that this functionality is working
Looking good @Immodal,
could you please add a simple unit test that ensures that this functionality is working
@Immodal check out the frontend tests. They basically just do a GET for most pages to make sure they're not broken.
If there's not one there for the profile page, you could add it. You might need to create some requested matches in the setup for the test.
Given the profile test already exists, I just added the match requests to the mixin. Hopefully I put it in the right spot.
I'm actually having some trouble running tests offline. When I try to run tests I get this error and I have no idea where to look to resolve this.
(python_env) PS C:\Users\Nigel\Desktop\Coding\aiarena-web> python manage.py test
Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'aiarena'@'%' to database 'test_aiarena'")
Given the profile test already exists, I just added the match requests to the mixin. Hopefully I put it in the right spot.
I'm actually having some trouble running tests offline. When I try to run tests I get this error and I have no idea where to look to resolve this.
(python_env) PS C:\Users\Nigel\Desktop\Coding\aiarena-web> python manage.py test Creating test database for alias 'default'... Got an error creating the test database: (1044, "Access denied for user 'aiarena'@'%' to database 'test_aiarena'")
try running this sql query
drop database aiarena;
create database aiarena;
drop database test_aiarena;
create database test_aiarena;
GRANT ALL PRIVILEGES ON aiarena.* TO 'aiarena'@'%';
GRANT ALL PRIVILEGES ON test_aiarena.* TO 'aiarena'@'%';
then run python manage.py seed
(this is just to make sure the db was refreshed properly)
and you should be set up
This was linked to issues
Dec 11, 2020
eladyaniv01 added a commit that referenced this pull request
- Add Icons for Trophies
- New TrophyIcon model to hold image for icon
- New TrophyIcon field in Trophy
- bot.html shows icon if it exists
- Updated admin.py
- Added highlights to bot avg step time
- Added step_time_color to core_filters.py
- Added color style to relevant cell in bot.html
Add trend indicators to main ranking page (#133)
Filter out requested matches from current_elo_trend
Add elo trend to season.html
Only show rank trending if change is over 10
Made n matches for ELO trend configurable
Better icons for trends to reflect the bot performance hopefully more accurately. (#134)
Elo trend icon title (#135)
Better icons for trends to reflect the bot performance hopefully more accurately.
ELO trend icon title specifies how much the ELO has actually changed.
Changed all ELO "not changing" icons from fast_rewind to trending_flat
Replaced arrow icons from trends (#136)
removed arrow icons from trends and replaced them with rotated trending_flat icons
Differentiate requested matches in result list (#139)
Ladder games with no ELO change will show as 0, whereas requested matches will show as "--" with no trend icons in bot.html, match.html, arenaclient.html and results.html
User that requested the match can be seen on the match page
List requested matches for bot authors in their profile page and allow cancellations (#142)
List requested matches for bot authors in their profile page #138
Cancel Requested Matches #87
- User can cancel matches requested by them from their profile page.
- Only matches that haven't been assigned to an arena client can be cancelled.
- On success or failure, a message will display at the top of the page.
- Right now only matches cancelled by them will refund their match requests
Added match requests to regularUser1 for frontend page render test
fix: fix wrong icon display in match detail view
Immodal added a commit that referenced this pull request
eladyaniv01 pushed a commit that referenced this pull request
Abbreviate Timestamps and Fixed arenaclient.html not loading
fix-CI-build
Latest version of pip causing issues with build: pypa/pip#9203 (comment)
Leaving pip unupgraded should fix issue.
- Fixed test to reflect recent text case update for PR #142
eladyaniv01 added a commit that referenced this pull request
Abbreviate Timestamps and Fixed arenaclient.html not loading (#149)
fix-CI-build (#149)
Fixed test to reflect recent text case update for PR (#142)
List matches that are being played or have been queued on the bot page (#146)
List matches that are being played or have been queued on the bot page
Update django.yml (removed pip upgrade command until pip fixes their latest verison)