List requested matches for bot authors in their profile page and allow cancellations by Immodal · Pull Request #142 · aiarena/aiarena-web (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits3 Checks0 Files changed

Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Immodal

#87 and #138

@lladdy @eladyaniv01
I'm not sure if the way I implemented it is the best way to do it, do let me know if you can think of how to improve it.

image

@Immodal

@Immodal

@eladyaniv01

Looking good @Immodal,
could you please add a simple unit test that ensures that this functionality is working

@lladdy

Looking good @Immodal,
could you please add a simple unit test that ensures that this functionality is working

@Immodal check out the frontend tests. They basically just do a GET for most pages to make sure they're not broken.
If there's not one there for the profile page, you could add it. You might need to create some requested matches in the setup for the test.

@Immodal

@Immodal

Given the profile test already exists, I just added the match requests to the mixin. Hopefully I put it in the right spot.

I'm actually having some trouble running tests offline. When I try to run tests I get this error and I have no idea where to look to resolve this.

(python_env) PS C:\Users\Nigel\Desktop\Coding\aiarena-web> python manage.py test
Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'aiarena'@'%' to database 'test_aiarena'")

@eladyaniv01

Given the profile test already exists, I just added the match requests to the mixin. Hopefully I put it in the right spot.

I'm actually having some trouble running tests offline. When I try to run tests I get this error and I have no idea where to look to resolve this.

(python_env) PS C:\Users\Nigel\Desktop\Coding\aiarena-web> python manage.py test
Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'aiarena'@'%' to database 'test_aiarena'")

try running this sql query

drop database aiarena;
create database aiarena;
drop database test_aiarena;
create database test_aiarena;
GRANT ALL PRIVILEGES ON aiarena.* TO 'aiarena'@'%';
GRANT ALL PRIVILEGES ON test_aiarena.* TO 'aiarena'@'%';

then run python manage.py seed (this is just to make sure the db was refreshed properly)
and you should be set up

This was linked to issues

Dec 11, 2020

eladyaniv01 added a commit that referenced this pull request

Dec 11, 2020

@eladyaniv01

Immodal added a commit that referenced this pull request

Dec 13, 2020

@Immodal

eladyaniv01 pushed a commit that referenced this pull request

Dec 13, 2020

@Immodal

…#149)

Latest version of pip causing issues with build: pypa/pip#9203 (comment)

Leaving pip unupgraded should fix issue.

eladyaniv01 added a commit that referenced this pull request

Dec 13, 2020

@eladyaniv01