24153 Destination Databricks: Fix support for external tables on S3 by suhomud · Pull Request #24657 · airbytehq/airbyte (original) (raw)

suhomud

@suhomud

@suhomud suhomud linked an issue

Mar 29, 2023

that may beclosed by this pull request

@suhomud

@suhomud suhomud changed the title24153 Destination Databricks: Update s3 source external 24153 Destination Databricks: Fix support for external tables on S3

Mar 29, 2023

@suhomud suhomud marked this pull request as ready for review

March 30, 2023 04:54

@evantahler

evantahler

@evantahler

@octavia-squidington-iii

@evantahler evantahler deleted the suhomud/destination-databricks-update-external-s3 branch

April 19, 2023 20:28

@edgao edgao mentioned this pull request

Apr 20, 2023

btkcodedev pushed a commit to btkcodedev/airbyte that referenced this pull request

Apr 26, 2023

…irbytehq#24657)


Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

marcosmarxm added a commit that referenced this pull request

May 1, 2023

This reverts commit 6615288b6d2441d9fdde2d927a5eb77b5d788442.


Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Visnu Pitiyanuvath visnup@gmail.com Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com


Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: arsenlosenko arsenlosenko@users.noreply.github.com


Co-authored-by: Ali Hassan alihassan01264@gmail.com Co-authored-by: Ali Hassan 62539376+Alihassanc5@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit e034d10.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

I gave a better description to the Airbyte Cloud section, converted a few passive words to active, and added a missing comma.

I noticed several punctuation marks were missing, so I fixed them. I also want to use this opportunity to draw get the attention of the docs team. I would love to join Airbyte as a technical writer and be a part of the team. I am more than willing to handle these tasks, even if the organization does not have the current budget to onboard a new technical writer.

Also, I filled the form to participate in the Airbyte Writer Program. I hope the team reviews my topic and allow me contribute to the data insight and tutorial articles. Cheers!


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: rodireich rodireich@users.noreply.github.com

Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: evantahler evantahler@users.noreply.github.com

This is no longer used with Move's move to Zenhub.


Co-authored-by: colesnodgrass colesnodgrass@users.noreply.github.com

This reverts commit d82bf88.

This reverts commit bc9bc61.

This reverts commit c594365.


Co-authored-by: girarda girarda@users.noreply.github.com

This reverts commit 961f0d6.


Co-authored-by: Rachel RIZK rachel.rizk@backmarket.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com Co-authored-by: sajarin sajarin@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Co-authored-by: Topher Lubaway asimplechris@gmail.com


Co-authored-by: girarda girarda@users.noreply.github.com

This reverts commit 6615288b6d2441d9fdde2d927a5eb77b5d788442.


Co-authored-by: Prateek Mukhedkar 123108018+prateekmukhedkar@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: girarda girarda@users.noreply.github.com


Co-authored-by: akashkulk akashkulk@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit bbdeb99.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit dc707f7.


Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: bnchrch bnchrch@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit b538a8c.


Co-authored-by: marcosmarxm marcosmarxm@users.noreply.github.com Co-authored-by: erohmensing erohmensing@users.noreply.github.com


Co-authored-by: bnchrch bnchrch@users.noreply.github.com

Co-authored-by: Catherine Noll clnoll@users.noreply.github.com


Co-authored-by: Serhii Lazebnyi 53845333+lazebnyi@users.noreply.github.com Co-authored-by: Catherine Noll clnoll@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Haithem Souala haithem.souala@woopit.fr Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit bbdeb99.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: subodh subodh1810@gmail.com Co-authored-by: subodh1810 subodh1810@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Sajarin sajarindider@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This commit refactors the DestinationCumulio class by removing some unused dummy variables and commented code that used to push data in the check method. Next to that I fixed a potential bug as pointed out by @grishick who reviewed this code (thanks for that!). Previously, the state message could have been yielded before any buffers were flushed, which could result in incorrectly indicating a synchronization has been completed while data could still be inside the buffer. Now, all buffers will be flushed before yielding that message.


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Sunny Hashmi 6833405+sh4sh@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit 06354ae.


Co-authored-by: artem1205 artem1205@users.noreply.github.com


Co-authored-by: edgao edgao@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

The currently generated Java destination code doesn't compile. Fix it up.

This reverts commit bbdeb99.

This reverts commit bbdeb99.

Co-authored-by: Mayank Vadariya 48036907+mayankvadariya@users.noreply.github.com

The decimal type in Hive will default to a precision of 10 and a scale of 0, meaning that it cannot handle numbers larger than 10 digits. The maximum values for precision and scale are 38 and 38 respectively. This updates the decimal type specified in destination schemas to use the maximum values for the broadest compatibility with numeric values.

If a table is using the default precision of 10 and a number is present which exceeds that many digits then the query engine will throw a fieldValue cannot be null error message which is very cryptic.


Co-authored-by: Tobias Macey tmacey@mit.edu


Co-authored-by: brianjlai brian.lai@airbyte.io Co-authored-by: girarda girarda@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: Mal Hancock mallory@archangelic.space Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Visnu Pitiyanuvath visnup@gmail.com Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Augustin augustin@airbyte.io Co-authored-by: Alexandre Girard alexandre@airbyte.io Co-authored-by: girarda girarda@users.noreply.github.com Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Artem Inzhyyants 36314070+artem1205@users.noreply.github.com Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com Co-authored-by: Arsen Losenko 20901439+arsenlosenko@users.noreply.github.com Co-authored-by: arsenlosenko arsenlosenko@users.noreply.github.com Co-authored-by: Ali Hassan alihassan01264@gmail.com Co-authored-by: Ali Hassan 62539376+Alihassanc5@users.noreply.github.com Co-authored-by: Serhii Lazebnyi 53845333+lazebnyi@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Boluwatife Victor 95125924+BirdboyBolu@users.noreply.github.com Co-authored-by: Rodi Reich Zilberman 867491+rodireich@users.noreply.github.com Co-authored-by: rodireich rodireich@users.noreply.github.com Co-authored-by: Philip Corr PhilipCorr@users.noreply.github.com Co-authored-by: Lake Mossman lake@airbyte.io Co-authored-by: evantahler evantahler@users.noreply.github.com Co-authored-by: Davin Chia davinchia@gmail.com Co-authored-by: Cole Snodgrass cole@airbyte.io Co-authored-by: colesnodgrass colesnodgrass@users.noreply.github.com Co-authored-by: timroes timroes@users.noreply.github.com Co-authored-by: Sajarin sajarindider@gmail.com Co-authored-by: Rachel RIZK rachel.rizk@backmarket.com Co-authored-by: sajarin sajarin@users.noreply.github.com Co-authored-by: Denys Davydov davydov.den18@gmail.com Co-authored-by: Tim Roes tim@airbyte.io Co-authored-by: Ben Church ben@airbyte.io Co-authored-by: Topher Lubaway asimplechris@gmail.com Co-authored-by: Jimmy Ma gosusnp@users.noreply.github.com Co-authored-by: Akash Kulkarni 113392464+akashkulk@users.noreply.github.com Co-authored-by: Ivica Taseski ivica.taseski94@gmail.com Co-authored-by: Prateek Mukhedkar 123108018+prateekmukhedkar@users.noreply.github.com Co-authored-by: Ryan Fu ryan.fu@airbyte.io Co-authored-by: richardlam-quotapath 113922446+richardlam-quotapath@users.noreply.github.com Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: akashkulk akashkulk@users.noreply.github.com Co-authored-by: Joe Reuter joe@airbyte.io Co-authored-by: bnchrch bnchrch@users.noreply.github.com Co-authored-by: Vladimir remar vladimir.remar@gmail.com Co-authored-by: Rachel Rizk 69161287+rach-r@users.noreply.github.com Co-authored-by: Catherine Noll clnoll@users.noreply.github.com Co-authored-by: Juan 80164312+jnr0790@users.noreply.github.com Co-authored-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Ella Rohm-Ensing erohmensing@gmail.com Co-authored-by: erohmensing erohmensing@users.noreply.github.com Co-authored-by: Haithem Souala haithem.souala@woopit.fr Co-authored-by: josephkmh josephkmh@users.noreply.github.com Co-authored-by: midavadim midavadim@yahoo.com Co-authored-by: Sergio Ropero 42538006+sergio-ropero@users.noreply.github.com Co-authored-by: subodh subodh1810@gmail.com Co-authored-by: subodh1810 subodh1810@users.noreply.github.com Co-authored-by: Conor cpdeethree@users.noreply.github.com Co-authored-by: Dominik Wagner dominik.r.mall2@gmail.com Co-authored-by: Yevhen Sukhomud suhomud@gmail.com Co-authored-by: Pedro S. Lopez pedroslopez@me.com Co-authored-by: Riley Brook riley@airbyte.io Co-authored-by: Cynthia Yin cynthia@airbyte.io Co-authored-by: Joost Stessens 77833265+jooststessens@users.noreply.github.com Co-authored-by: Ana Loureiro 37600275+anamargaridarl@users.noreply.github.com Co-authored-by: Edward Gao edward.gao@airbyte.io Co-authored-by: edgao edgao@users.noreply.github.com Co-authored-by: Chris Wu chris@faros.ai Co-authored-by: iberchid 93732608+iberchid@users.noreply.github.com Co-authored-by: Pekka Enberg penberg@iki.fi Co-authored-by: Mayank Vadariya 48036907+mayankvadariya@users.noreply.github.com Co-authored-by: Tobias Macey tmacey@mit.edu Co-authored-by: brianjlai brian.lai@airbyte.io Co-authored-by: JJ Nilbodee pornwipa.nil@gmail.com Co-authored-by: Mal Hancock mallory@archangelic.space

marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request

Jun 8, 2023

…irbytehq#24657)


Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request

Jun 8, 2023

This reverts commit 6615288b6d2441d9fdde2d927a5eb77b5d788442.


Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Visnu Pitiyanuvath visnup@gmail.com Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com


Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: arsenlosenko arsenlosenko@users.noreply.github.com


Co-authored-by: Ali Hassan alihassan01264@gmail.com Co-authored-by: Ali Hassan 62539376+Alihassanc5@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit e034d10.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

I gave a better description to the Airbyte Cloud section, converted a few passive words to active, and added a missing comma.

I noticed several punctuation marks were missing, so I fixed them. I also want to use this opportunity to draw get the attention of the docs team. I would love to join Airbyte as a technical writer and be a part of the team. I am more than willing to handle these tasks, even if the organization does not have the current budget to onboard a new technical writer.

Also, I filled the form to participate in the Airbyte Writer Program. I hope the team reviews my topic and allow me contribute to the data insight and tutorial articles. Cheers!


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: rodireich rodireich@users.noreply.github.com

Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: evantahler evantahler@users.noreply.github.com

This is no longer used with Move's move to Zenhub.


Co-authored-by: colesnodgrass colesnodgrass@users.noreply.github.com

This reverts commit d82bf88.

This reverts commit bc9bc61.

This reverts commit c594365.


Co-authored-by: girarda girarda@users.noreply.github.com

This reverts commit 961f0d6.


Co-authored-by: Rachel RIZK rachel.rizk@backmarket.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com Co-authored-by: sajarin sajarin@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Co-authored-by: Topher Lubaway asimplechris@gmail.com


Co-authored-by: girarda girarda@users.noreply.github.com

This reverts commit 6615288b6d2441d9fdde2d927a5eb77b5d788442.


Co-authored-by: Prateek Mukhedkar 123108018+prateekmukhedkar@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: girarda girarda@users.noreply.github.com


Co-authored-by: akashkulk akashkulk@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit bbdeb99.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit dc707f7.


Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: bnchrch bnchrch@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit b538a8c.


Co-authored-by: marcosmarxm marcosmarxm@users.noreply.github.com Co-authored-by: erohmensing erohmensing@users.noreply.github.com


Co-authored-by: bnchrch bnchrch@users.noreply.github.com

Co-authored-by: Catherine Noll clnoll@users.noreply.github.com


Co-authored-by: Serhii Lazebnyi 53845333+lazebnyi@users.noreply.github.com Co-authored-by: Catherine Noll clnoll@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Haithem Souala haithem.souala@woopit.fr Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit bbdeb99.


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: subodh subodh1810@gmail.com Co-authored-by: subodh1810 subodh1810@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com

Signed-off-by: Henri Blancke blanckehenri@gmail.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Sajarin sajarindider@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This commit refactors the DestinationCumulio class by removing some unused dummy variables and commented code that used to push data in the check method. Next to that I fixed a potential bug as pointed out by @grishick who reviewed this code (thanks for that!). Previously, the state message could have been yielded before any buffers were flushed, which could result in incorrectly indicating a synchronization has been completed while data could still be inside the buffer. Now, all buffers will be flushed before yielding that message.


Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com


Co-authored-by: Sunny Hashmi 6833405+sh4sh@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

This reverts commit 06354ae.


Co-authored-by: artem1205 artem1205@users.noreply.github.com


Co-authored-by: edgao edgao@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com

The currently generated Java destination code doesn't compile. Fix it up.

This reverts commit bbdeb99.

This reverts commit bbdeb99.

Co-authored-by: Mayank Vadariya 48036907+mayankvadariya@users.noreply.github.com

The decimal type in Hive will default to a precision of 10 and a scale of 0, meaning that it cannot handle numbers larger than 10 digits. The maximum values for precision and scale are 38 and 38 respectively. This updates the decimal type specified in destination schemas to use the maximum values for the broadest compatibility with numeric values.

If a table is using the default precision of 10 and a number is present which exceeds that many digits then the query engine will throw a fieldValue cannot be null error message which is very cryptic.


Co-authored-by: Tobias Macey tmacey@mit.edu


Co-authored-by: brianjlai brian.lai@airbyte.io Co-authored-by: girarda girarda@users.noreply.github.com


Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: Mal Hancock mallory@archangelic.space Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com


Signed-off-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Visnu Pitiyanuvath visnup@gmail.com Co-authored-by: Sherif A. Nada snadalive@gmail.com Co-authored-by: sh4sh 6833405+sh4sh@users.noreply.github.com Co-authored-by: Marcos Marx marcosmarxm@users.noreply.github.com Co-authored-by: Augustin augustin@airbyte.io Co-authored-by: Alexandre Girard alexandre@airbyte.io Co-authored-by: girarda girarda@users.noreply.github.com Co-authored-by: Evan Tahler evan@airbyte.io Co-authored-by: Artem Inzhyyants 36314070+artem1205@users.noreply.github.com Co-authored-by: artem1205 artem1205@users.noreply.github.com Co-authored-by: Octavia Squidington III octavia-squidington-iii@users.noreply.github.com Co-authored-by: Arsen Losenko 20901439+arsenlosenko@users.noreply.github.com Co-authored-by: arsenlosenko arsenlosenko@users.noreply.github.com Co-authored-by: Ali Hassan alihassan01264@gmail.com Co-authored-by: Ali Hassan 62539376+Alihassanc5@users.noreply.github.com Co-authored-by: Serhii Lazebnyi 53845333+lazebnyi@users.noreply.github.com Co-authored-by: marcosmarxm marcosmarxm@gmail.com Co-authored-by: Boluwatife Victor 95125924+BirdboyBolu@users.noreply.github.com Co-authored-by: Rodi Reich Zilberman 867491+rodireich@users.noreply.github.com Co-authored-by: rodireich rodireich@users.noreply.github.com Co-authored-by: Philip Corr PhilipCorr@users.noreply.github.com Co-authored-by: Lake Mossman lake@airbyte.io Co-authored-by: evantahler evantahler@users.noreply.github.com Co-authored-by: Davin Chia davinchia@gmail.com Co-authored-by: Cole Snodgrass cole@airbyte.io Co-authored-by: colesnodgrass colesnodgrass@users.noreply.github.com Co-authored-by: timroes timroes@users.noreply.github.com Co-authored-by: Sajarin sajarindider@gmail.com Co-authored-by: Rachel RIZK rachel.rizk@backmarket.com Co-authored-by: sajarin sajarin@users.noreply.github.com Co-authored-by: Denys Davydov davydov.den18@gmail.com Co-authored-by: Tim Roes tim@airbyte.io Co-authored-by: Ben Church ben@airbyte.io Co-authored-by: Topher Lubaway asimplechris@gmail.com Co-authored-by: Jimmy Ma gosusnp@users.noreply.github.com Co-authored-by: Akash Kulkarni 113392464+akashkulk@users.noreply.github.com Co-authored-by: Ivica Taseski ivica.taseski94@gmail.com Co-authored-by: Prateek Mukhedkar 123108018+prateekmukhedkar@users.noreply.github.com Co-authored-by: Ryan Fu ryan.fu@airbyte.io Co-authored-by: richardlam-quotapath 113922446+richardlam-quotapath@users.noreply.github.com Co-authored-by: Mal Hancock mhancock@archangelic.space Co-authored-by: akashkulk akashkulk@users.noreply.github.com Co-authored-by: Joe Reuter joe@airbyte.io Co-authored-by: bnchrch bnchrch@users.noreply.github.com Co-authored-by: Vladimir remar vladimir.remar@gmail.com Co-authored-by: Rachel Rizk 69161287+rach-r@users.noreply.github.com Co-authored-by: Catherine Noll clnoll@users.noreply.github.com Co-authored-by: Juan 80164312+jnr0790@users.noreply.github.com Co-authored-by: Henri Blancke blanckehenri@gmail.com Co-authored-by: Ella Rohm-Ensing erohmensing@gmail.com Co-authored-by: erohmensing erohmensing@users.noreply.github.com Co-authored-by: Haithem Souala haithem.souala@woopit.fr Co-authored-by: josephkmh josephkmh@users.noreply.github.com Co-authored-by: midavadim midavadim@yahoo.com Co-authored-by: Sergio Ropero 42538006+sergio-ropero@users.noreply.github.com Co-authored-by: subodh subodh1810@gmail.com Co-authored-by: subodh1810 subodh1810@users.noreply.github.com Co-authored-by: Conor cpdeethree@users.noreply.github.com Co-authored-by: Dominik Wagner dominik.r.mall2@gmail.com Co-authored-by: Yevhen Sukhomud suhomud@gmail.com Co-authored-by: Pedro S. Lopez pedroslopez@me.com Co-authored-by: Riley Brook riley@airbyte.io Co-authored-by: Cynthia Yin cynthia@airbyte.io Co-authored-by: Joost Stessens 77833265+jooststessens@users.noreply.github.com Co-authored-by: Ana Loureiro 37600275+anamargaridarl@users.noreply.github.com Co-authored-by: Edward Gao edward.gao@airbyte.io Co-authored-by: edgao edgao@users.noreply.github.com Co-authored-by: Chris Wu chris@faros.ai Co-authored-by: iberchid 93732608+iberchid@users.noreply.github.com Co-authored-by: Pekka Enberg penberg@iki.fi Co-authored-by: Mayank Vadariya 48036907+mayankvadariya@users.noreply.github.com Co-authored-by: Tobias Macey tmacey@mit.edu Co-authored-by: brianjlai brian.lai@airbyte.io Co-authored-by: JJ Nilbodee pornwipa.nil@gmail.com Co-authored-by: Mal Hancock mallory@archangelic.space