[MNG-6847] Use diamond operator by timtebeek · Pull Request #96 · apache/maven-ear-plugin (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

apache / maven-ear-plugin Public

• Notifications You must be signed in to change notification settings

• Fork28

• Star 12

• Code

• Issues 10

• Pull requests

• Actions

• Security and quality

• Insights

Additional navigation options

Merged

elharo

merged 1 commit into

apache:masterfrom

timtebeek:refactor/use-diamond-operator

Aug 30, 2023

ConversationCommits (1)ChecksFiles changed

Merged

[MNG-6847] Use diamond operator#96

elharo

merged 1 commit into

apache:masterfrom

timtebeek:refactor/use-diamond-operator

Conversation

timtebeek commented

Aug 19, 2023

Copy link Copy Markdown

Contributor

As discussed on

• [MNG-6847] Use diamond operator maven-scm#184
• https://issues.apache.org/jira/browse/MNG-6847

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu

`[[MNG-6847] Use diamond operator](/apache/maven-ear-plugin/pull/96/commits/c3892df8a6c0bbf5a530f50728ac61cd57481535 "[MNG-6847] Use diamond operator

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu

Co-authored-by: Moderne team@moderne.io") `

[c3892df](/apache/maven-ear-plugin/pull/96/commits/c3892df8a6c0bbf5a530f50728ac61cd57481535)

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu

Co-authored-by: Moderne team@moderne.io

olamy commented

Aug 20, 2023

•

edited

Loading

Copy link Copy Markdown

Member

this should be MEAR not MNG as it's plugin change not a core change

timtebeek commented

Aug 20, 2023

Copy link Copy Markdown

Contributor Author

this should be MEAR not MNG as it's plugin change not a core change

Thanks for voicing your concern! I've written up a bit more context about these code changes and earlier Jira ticket issue discussions in

• [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy maven-scm#183 (comment)

Linked here for convenience; I suggest we discuss it there, or through the Mailinglist or Slack.

timtebeek commented

Aug 30, 2023

Copy link Copy Markdown

Contributor Author

@elharo would you mind reviewing this one as well?

elharo approved these changes Aug 30, 2023

View reviewed changes

elharo merged commit 400a2d2 into apache:master

Aug 30, 2023

slawekjaranowski assigned elharo

Jun 9, 2025

slawekjaranowski added this to the 3.4.0 milestone

Jun 9, 2025

slawekjaranowski added the maintenance label

Jun 9, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

elharo elharo approved these changes

Assignees

elharo

Labels

maintenance

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants