Include "[ci skip]" by default in scmReleaseCommitComment by kwin · Pull Request #1423 · apache/maven-release (original) (raw)
kwin changed the title
Include "[ci-skip]" by default in scmReleaseCommitComment Include "[ci skip]" by default in scmReleaseCommitComment
kwin deleted the feature/ci-skip branch
nomis mentioned this pull request
rvesse added a commit to rvesse/maven-release that referenced this pull request
This reverts PR apache#1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
rvesse added a commit to rvesse/maven-release that referenced this pull request
This reverts PR apache#1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
kwin pushed a commit that referenced this pull request
This reverts PR #1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})