[MRELEASE-1103] Wrong file path used for master pw file by cstamas · Pull Request #181 · apache/maven-release (original) (raw)
Interesting: branch has 4 commits, but this PR shows only 3 of them?
There is next place where we copy code and have many implementations for the same things ...
Eg in MavenCli we do similar ...
We can think about dedicated service for decryption/encryption which can use more secure system keychains or external crypto devices - but it is another topic ... I'm not an expert on it ... 😄
| this.plexusCipher = plexusCipher; |
|---|
| // Adjust the default path (def path != maven path) |
| this.secDispatcher.setConfigurationFile("~/.m2/settings-security.xml"); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? I'm not sure. Windows and even on unix system?
It would be better to use something such System.getProperty("user.home")+"/.m2/settings-security.xml"
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, sec dispatcher resolves this for us.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto. I wish Java could do it as well :)
well maybe a comment as it is not very intuitive. Image when some archeologists will have a look at this code with the new Maven dependencies cleanup in few years
…(works with 2.5.3)
Wrong file path used for master password file. Using plexus default, that is NOT same as Maven default.
This closes #181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})