[MSHADE-417] Fix null bytes appended to small files by gnodet · Pull Request #160 · apache/maven-shade-plugin (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

apache / maven-shade-plugin Public

Additional navigation options

Merged

gnodet

merged 3 commits into

apache:masterfrom

gnodet:MSHADE-417

Oct 20, 2022

ConversationCommits (3)ChecksFiles changed

Merged

[MSHADE-417] Fix null bytes appended to small files#160

gnodet

merged 3 commits into

apache:masterfrom

gnodet:MSHADE-417

Conversation

@gnodet

@gnodet gnodet commented

Oct 20, 2022

edited

Loading

Copy link Copy Markdown

Contributor

Supersedes #140
JIRA issue: https://issues.apache.org/jira/browse/MSHADE-417
Added a unit test.

@gnodet gnodet added this to the 3.4.1 milestone

Oct 20, 2022

@olamy olamy added the bug

Something isn't working

label

Oct 20, 2022

@gnodet gnodet requested a review from olamy

October 20, 2022 12:57

NichtStudioCode and others added 3 commits

October 20, 2022 17:21

@NichtStudioCode @gnodet

[Fix MSHADE-417](/apache/maven-shade-plugin/pull/160/commits/7d2aa2662c94bf9c7e28bf1c89dae5ff2117289b "Fix MSHADE-417")

[7d2aa26](/apache/maven-shade-plugin/pull/160/commits/7d2aa2662c94bf9c7e28bf1c89dae5ff2117289b)

@NichtStudioCode @gnodet

[don't unread when nothing was read](/apache/maven-shade-plugin/pull/160/commits/f3e71308fa42ccb917262cb018001165d35eaf2c "don't unread when nothing was read")

[f3e7130](/apache/maven-shade-plugin/pull/160/commits/f3e71308fa42ccb917262cb018001165d35eaf2c)

@gnodet

[Add a unit test](/apache/maven-shade-plugin/pull/160/commits/82d53e5a55eaed37ea68f7e706ccadda2ca617c2 "Add a unit test")

[82d53e5](/apache/maven-shade-plugin/pull/160/commits/82d53e5a55eaed37ea68f7e706ccadda2ca617c2)

@gnodet gnodet force-pushed the MSHADE-417 branch from62884f5 to82d53e5 Compare

October 20, 2022 15:25

@gnodet gnodet requested review fromcstamas and rmannibucau

October 20, 2022 15:26

rmannibucau

rmannibucau approved these changes Oct 20, 2022

View reviewed changes

khmarbaise

khmarbaise approved these changes Oct 20, 2022

View reviewed changes

@gnodet gnodet merged commit 0945bcb into apache:master

Oct 20, 2022

@jira-importer

jira-importer commented

Jun 14, 2025

Copy link Copy Markdown

Resolve #662

1 similar comment

@jira-importer

jira-importer commented

Jun 14, 2025

Copy link Copy Markdown

Resolve #662

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@rmannibucau rmannibucau rmannibucau approved these changes

@olamy olamy Awaiting requested review from olamy

@cstamas cstamas Awaiting requested review from cstamas

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@gnodet @jira-importer @khmarbaise @rmannibucau @olamy @NichtStudioCode