[MSHADE-417] Fix null bytes appended to small files by gnodet · Pull Request #160 · apache/maven-shade-plugin (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
apache / maven-shade-plugin Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 3 commits into
apache:masterfrom
Oct 20, 2022
ConversationCommits (3)ChecksFiles changed
Merged
[MSHADE-417] Fix null bytes appended to small files#160
merged 3 commits into
apache:masterfrom
Conversation
gnodet commented
•
edited
Loading
Copy link Copy Markdown
Contributor
Supersedes #140
JIRA issue: https://issues.apache.org/jira/browse/MSHADE-417
Added a unit test.
gnodet added this to the 3.4.1 milestone
Something isn't working
label
gnodet requested a review from olamy
NichtStudioCode and others added 3 commits
[Fix MSHADE-417](/apache/maven-shade-plugin/pull/160/commits/7d2aa2662c94bf9c7e28bf1c89dae5ff2117289b "Fix MSHADE-417")
[7d2aa26](/apache/maven-shade-plugin/pull/160/commits/7d2aa2662c94bf9c7e28bf1c89dae5ff2117289b)
[don't unread when nothing was read](/apache/maven-shade-plugin/pull/160/commits/f3e71308fa42ccb917262cb018001165d35eaf2c "don't unread when nothing was read")
[f3e7130](/apache/maven-shade-plugin/pull/160/commits/f3e71308fa42ccb917262cb018001165d35eaf2c)
[Add a unit test](/apache/maven-shade-plugin/pull/160/commits/82d53e5a55eaed37ea68f7e706ccadda2ca617c2 "Add a unit test")
[82d53e5](/apache/maven-shade-plugin/pull/160/commits/82d53e5a55eaed37ea68f7e706ccadda2ca617c2)
gnodet force-pushed the MSHADE-417 branch from62884f5 to82d53e5 Compare
gnodet requested review fromcstamas and rmannibucau
rmannibucau approved these changes Oct 20, 2022
khmarbaise approved these changes Oct 20, 2022
gnodet merged commit 0945bcb into apache:master
jira-importer commented
Copy link Copy Markdown
Resolve #662
1 similar comment
jira-importer commented
Copy link Copy Markdown
Resolve #662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
khmarbaise khmarbaise approved these changes
rmannibucau rmannibucau approved these changes
olamy Awaiting requested review from olamy
cstamas Awaiting requested review from cstamas
Assignees
No one assigned
Labels
Something isn't working
Projects
None yet
Milestone
Development
Successfully merging this pull request may close these issues.