Prefer Guice injection by elharo · Pull Request #79 · apache/maven-war-plugin (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
apache / maven-war-plugin Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 2 commits into
masterfrom
Dec 26, 2024
ConversationCommits (2)ChecksFiles changed
Merged
merged 2 commits into
masterfrom
Conversation
elharo commented
Copy link Copy Markdown
Contributor
No description provided.
[Prefer Guice injection](/apache/maven-war-plugin/pull/79/commits/8eb9309f876912ee49c532321253b53da8f32dee "Prefer Guice injection")
[8eb9309](/apache/maven-war-plugin/pull/79/commits/8eb9309f876912ee49c532321253b53da8f32dee)
elharo marked this pull request as ready for review
elharo requested a review from slachiewicz
slachiewicz removed their request for review
[Remove plexus components.xml](/apache/maven-war-plugin/pull/79/commits/30489b64eba1013c40045080253c6910e564e63d "Remove plexus components.xml")
[30489b6](/apache/maven-war-plugin/pull/79/commits/30489b64eba1013c40045080253c6910e564e63d)
elharo requested a review from slawekjaranowski
Bukama approved these changes Dec 25, 2024
Bukama left a comment
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non binding approval
slachiewicz approved these changes Dec 26, 2024
elharo merged commit 1e267a6 into master
elharo deleted the guice branch
slawekjaranowski added the maintenance label
slawekjaranowski assigned elharo
slawekjaranowski added this to the 3.4.1 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
Bukama Bukama approved these changes
slachiewicz slachiewicz approved these changes
slawekjaranowski Awaiting requested review from slawekjaranowski
Assignees
Labels
Projects
None yet
Milestone
Development
Successfully merging this pull request may close these issues.