Removed unused commons fileupload wrapper. by mbien · Pull Request #9121 · apache/netbeans (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

apache / netbeans Public

Additional navigation options

Merged

mbien merged 1 commit intoapache:masterfrom

mbien:remove-fileupload

Jan 11, 2026

ConversationCommits (1)ChecksFiles changed

Merged

Removed unused commons fileupload wrapper.#9121

mbien merged 1 commit intoapache:masterfrom

mbien:remove-fileupload

Conversation

@mbien

Copy link Copy Markdown

Member

@mbien mbien commented

Jan 3, 2026

edited

Loading

also removed commons_net dependency declaration from jenkins module

couldn't find any usage, potentially a leftover from #9051

@mbien

`[Remove unused commons fileupload wrapper.](/apache/netbeans/pull/9121/commits/f0db87ce92062c6e7d35226ca6bd03e3ddf5a1ba "Remove unused commons fileupload wrapper.

also removed commons_net dependency declaration from jenkins module") `

[f0db87c](/apache/netbeans/pull/9121/commits/f0db87ce92062c6e7d35226ca6bd03e3ddf5a1ba)

also removed commons_net dependency declaration from jenkins module

@mbien mbien added this to the NB29 milestone

Jan 3, 2026

@mbien mbien added Code cleanup

Label for cleanup done on the Netbeans IDE

Upgrade Library

Library (Dependency) Upgrade

ci:all-tests

[ci] enable all tests

ci:dev-build

[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)

enterprise

[ci] enable enterprise job

and removed ci:all-tests

[ci] enable all tests

labels

Jan 3, 2026

@mbien mbien marked this pull request as ready for review

January 3, 2026 03:28

@mbien mbien requested review fromlkishalmi, matthiasblaesing and neilcsmith-net

January 11, 2026 01:25

matthiasblaesing

matthiasblaesing approved these changes Jan 11, 2026

View reviewed changes

Copy link Copy Markdown

Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

lkishalmi

lkishalmi approved these changes Jan 11, 2026

View reviewed changes

Copy link Copy Markdown

Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mbien

Copy link Copy Markdown

Member Author

mbien commented

Jan 11, 2026

cool, thanks for the reviews!

@mbien mbien merged commit ae6273d into apache:master

Jan 11, 2026

79 of 80 checks passed

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lkishalmi lkishalmi lkishalmi approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

Assignees

No one assigned

Labels

ci:dev-build

[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)

Code cleanup

Label for cleanup done on the Netbeans IDE

enterprise

[ci] enable enterprise job

Upgrade Library

Library (Dependency) Upgrade

Projects

None yet

Milestone

NB29

Development

Successfully merging this pull request may close these issues.

3 participants

@mbien @lkishalmi @matthiasblaesing