Add rustfmt.toml file by dcreager · Pull Request #18197 · astral-sh/ruff (original) (raw)

added 2 commits

May 19, 2025 11:06

@dcreager

@dcreager

@dcreager

MichaReiser

dcreager added a commit that referenced this pull request

May 19, 2025

@dcreager

BurntSushi added a commit to astral-sh/uv that referenced this pull request

Jun 16, 2025

@BurntSushi

We've gotten away without this file for a while. In particular, we explicitly use its default settings.

However, this is occasionally problematic in certain contexts where rustfmt is invoked directly. Or in contexts where the Rust Edition is otherwise not specified. At least, this happens when using the Rust vim plugin. When an edition isn't explicitly specified, it defaults back to the 2015 edition.

I think that there aren't a lot of rustfmt changes, and so we've been able to get away with this for a while. But it looks like something in the 2024 edition changes how imports are ordered. So to make it explicit that we want to use the 2024 edition of rustfmt, we opt into it.

This is analogous to a change made to the Ruff repository somewhat recently: astral-sh/ruff#18197

BurntSushi added a commit to astral-sh/uv that referenced this pull request

Jun 16, 2025

@BurntSushi

We've gotten away without this file for a while. In particular, we explicitly use its default settings.

However, this is occasionally problematic in certain contexts where rustfmt is invoked directly. Or in contexts where the Rust Edition is otherwise not specified. At least, this happens when using the Rust vim plugin. When an edition isn't explicitly specified, it defaults back to the 2015 edition.

I think that there aren't a lot of rustfmt changes, and so we've been able to get away with this for a while. But it looks like something in the 2024 edition changes how imports are ordered. So to make it explicit that we want to use the 2024 edition of rustfmt, we opt into it.

This is analogous to a change made to the Ruff repository somewhat recently: astral-sh/ruff#18197

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})