Fix mdtest ignore python code blocks by MatthewMckee4 · Pull Request #20139 · astral-sh/ruff (original) (raw)

dcreager added a commit that referenced this pull request

Aug 28, 2025

• main: Fix mdtest ignore python code blocks (#20139) [ty] add support for cyclic legacy generic protocols (#20125) [ty] add cycle detection for find_legacy_typevars (#20124) Use new diff rendering format in tests (#20101) [ty] Fix 'too many cycle iterations' for unions of literals (#20137) [ty] No boundness analysis for implicit instance attributes (#20128) Bump 0.12.11 (#20136) [ty] Benchmarks for problematic implicit instance attributes cases (#20133) [pyflakes] Fix allowed-unused-imports matching for top-level modules (F401) (#20115) Move GitLab output rendering to ruff_db (#20117) [ty] Evaluate reachability of non-definitely-bound to Ambiguous (#19579) [ty] Introduce a representation for the top/bottom materialization of an invariant generic (#20076) [flake8-async] Implement blocking-http-call-httpx (ASYNC212) (#20091) [ty] print diagnostics with fully qualified name to disambiguate some cases (#19850) [ruff] Preserve relative whitespace in multi-line expressions (RUF033) (#19647)

second-ed pushed a commit to second-ed/ruff that referenced this pull request

Sep 9, 2025

Summary

Resolves astral-sh/ty#1103

Test Plan

Edited crates/ty_python_semantic/resources/mdtest/literal/boolean.md with:

# Boolean literals

```python
reveal_type(True)  # revealed: Literal[False]
reveal_type(False)  # revealed: Literal[False]

Ran cargo test -p ty_python_semantic --test mdtest -- mdtest__literal_boolean

And we get a test failure:

running 1 test
test mdtest__literal_boolean ... FAILED

failures:

---- mdtest__literal_boolean stdout ----

boolean.md - Boolean literals (c336e1af3d538acd)

crates/ty_python_semantic/resources/mdtest/literal/boolean.md:4
unmatched assertion: revealed: Literal[False]
crates/ty_python_semantic/resources/mdtest/literal/boolean.md:4
unexpected error: 13 [revealed-type] "Revealed type: `Literal[True]`"

To rerun this specific test, set the environment variable:
MDTEST_TEST_FILTER='boolean.md - Boolean literals (c336e1af3d538acd)'
MDTEST_TEST_FILTER='boolean.md - Boolean literals (c336e1af3d538acd)'
cargo test -p ty_python_semantic --test mdtest --
mdtest__literal_boolean

--------------------------------------------------


thread 'mdtest__literal_boolean' panicked at
crates/ty_test/src/lib.rs:138:5:
Some tests failed.
note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace


failures:
    mdtest__literal_boolean

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 263
filtered out; finished in 0.18s

error: test failed, to rerun pass `-p ty_python_semantic --test mdtest`

As expected.

And when i checkout main and keep the same mdtest file all tests pass (as the repro).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})